[PR #654] [MERGED] Adds overflow:auto to popup content to allow it to scroll in lower res. #5685

New Issue

OVERLORD · 2026-02-05T10:14:07+03:00

OVERLORD commented

2026-02-05 10:14:07 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/654
Author: @Abijeet
Created: 1/5/2018
Status: ✅ Merged
Merged: 1/28/2018
Merged by: @ssddanbrown

Base: master ← Head: bug-650

📝 Commits (1)

f2c6276 Adds overflow:auto to popup content to allow it to scroll in lower res.

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 resources/assets/sass/_components.scss (+4 -0)
📝 resources/views/components/code-editor.blade.php (+1 -1)

📄 Description

Towards #650

Although adding a scroll-bar to the modal although is a fairly simple solution, it causes two scroll-bars to appear on the popup if the content in the code editor is more.

@ssddanbrown - Any ideas?

Signed-off-by: Abijeet abijeetpatro@gmail.com

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/654 **Author:** [@Abijeet](https://github.com/Abijeet) **Created:** 1/5/2018 **Status:** ✅ Merged **Merged:** 1/28/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `bug-650` --- ### 📝 Commits (1) - [`f2c6276`](https://github.com/BookStackApp/BookStack/commit/f2c62765cae4684709b7094f5aa9b98986b568a6) Adds overflow:auto to popup content to allow it to scroll in lower res. ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/sass/_components.scss` (+4 -0) 📝 `resources/views/components/code-editor.blade.php` (+1 -1) </details> ### 📄 Description Towards #650 Although adding a scroll-bar to the modal although is a fairly simple solution, it causes two scroll-bars to appear on the popup if the content in the code editor is more. ![screen shot 2018-01-06 at 01 38 23](https://user-images.githubusercontent.com/1685517/34626366-677a3e40-f282-11e7-9617-cd867121a01a.png) @ssddanbrown - Any ideas? Signed-off-by: Abijeet <abijeetpatro@gmail.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:14:07 +03:00

OVERLORD closed this issue

2026-02-05 10:14:09 +03:00

OVERLORD referenced this issue

2026-02-05 10:35:16 +03:00

[PR #5685] [MERGED] Tri-layout sidebar enhancements #6548

Sign in to join this conversation.