[PR #632] [MERGED] draw.io integration #5680

New Issue

OVERLORD · 2026-02-05T10:14:00+03:00

OVERLORD commented

2026-02-05 10:14:00 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/632
Author: @ssddanbrown
Created: 12/24/2017
Status: ✅ Merged
Merged: 1/28/2018
Merged by: @ssddanbrown

Base: master ← Head: draw.io

📝 Commits (10+)

0dc1f0b Started draw.io integration
920964a Enabled system-storage of drawings made via draw.io
1bfd77e Added drawing update ability
34782fb Merge branch 'master' into draw.io
0c383ee Merge branch 'master' into draw.io to fetch auth image changes
5626455 Added drawing icon and made drawio disablable
1411ee8 Extracted draw.io functionality to own file
9bbef3a Added drawio abilities to markdown editor
88d09a2 Added drawing endpoint tests
ba6eb67 Fixed test failing from missing baseURL

📊 Changes

22 files changed (+730 additions, -50 deletions)

View changed files

📝 app/Http/Controllers/ImageController.php (+77 -1)
📝 app/Repos/ImageRepo.php (+58 -3)
📝 app/Services/ImageService.php (+57 -0)
📝 config/services.php (+5 -0)
➕ public/system_images/drawing.svg (+107 -0)
📝 resources/assets/js/components/markdown-editor.js (+84 -4)
📝 resources/assets/js/libs/code.js (+0 -0)
➕ resources/assets/js/libs/drawio.js (+69 -0)
📝 resources/assets/js/pages/page-form.js (+111 -8)
📝 resources/assets/js/pages/page-show.js (+1 -1)
📝 resources/assets/js/vues/code-editor.js (+1 -1)
📝 resources/assets/sass/_forms.scss (+11 -6)
📝 resources/assets/sass/styles.scss (+12 -0)
📝 resources/lang/en/entities.php (+1 -0)
📝 resources/lang/en/errors.php (+1 -0)
📝 resources/views/pages/form.blade.php (+11 -1)
📝 routes/web.php (+4 -1)
📝 tests/BrowserKitTest.php (+4 -5)
📝 tests/ImageTest.php (+110 -19)
📝 tests/TestCase.php (+6 -0)

...and 2 more files

📄 Description

Relates to #619.

Very much a WIP at time of creating pull request.

TODO

Add updating of existing images.
Implement within markdown editor.
Add some basic testing to new endpoints.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/632 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 12/24/2017 **Status:** ✅ Merged **Merged:** 1/28/2018 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `draw.io` --- ### 📝 Commits (10+) - [`0dc1f0b`](https://github.com/BookStackApp/BookStack/commit/0dc1f0b07fbedb0df78a659b2ce65b3fa5dc2259) Started draw.io integration - [`920964a`](https://github.com/BookStackApp/BookStack/commit/920964a5612494bb1f25223b7c1de1379096c848) Enabled system-storage of drawings made via draw.io - [`1bfd77e`](https://github.com/BookStackApp/BookStack/commit/1bfd77e7a15cd52b2ccfa221ea90019438c2fbc1) Added drawing update ability - [`34782fb`](https://github.com/BookStackApp/BookStack/commit/34782fbc912f0a2e5d8329953905d13c601f8d21) Merge branch 'master' into draw.io - [`0c383ee`](https://github.com/BookStackApp/BookStack/commit/0c383eee5badf7fef3dbc643fae017d98e726750) Merge branch 'master' into draw.io to fetch auth image changes - [`5626455`](https://github.com/BookStackApp/BookStack/commit/56264551e7a616c363ce817513d216f967abba43) Added drawing icon and made drawio disablable - [`1411ee8`](https://github.com/BookStackApp/BookStack/commit/1411ee86b3f70013b3fd7735e3a504ebe15a154e) Extracted draw.io functionality to own file - [`9bbef3a`](https://github.com/BookStackApp/BookStack/commit/9bbef3a3dd75b9cdaf126835fab318f2f216ffc5) Added drawio abilities to markdown editor - [`88d09a2`](https://github.com/BookStackApp/BookStack/commit/88d09a2a3b76a2d914d523dc03fcf695849ba1b7) Added drawing endpoint tests - [`ba6eb67`](https://github.com/BookStackApp/BookStack/commit/ba6eb6727ad4e3b91a2d28ccdc021226a2e4df8f) Fixed test failing from missing baseURL ### 📊 Changes **22 files changed** (+730 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/ImageController.php` (+77 -1) 📝 `app/Repos/ImageRepo.php` (+58 -3) 📝 `app/Services/ImageService.php` (+57 -0) 📝 `config/services.php` (+5 -0) ➕ `public/system_images/drawing.svg` (+107 -0) 📝 `resources/assets/js/components/markdown-editor.js` (+84 -4) 📝 `resources/assets/js/libs/code.js` (+0 -0) ➕ `resources/assets/js/libs/drawio.js` (+69 -0) 📝 `resources/assets/js/pages/page-form.js` (+111 -8) 📝 `resources/assets/js/pages/page-show.js` (+1 -1) 📝 `resources/assets/js/vues/code-editor.js` (+1 -1) 📝 `resources/assets/sass/_forms.scss` (+11 -6) 📝 `resources/assets/sass/styles.scss` (+12 -0) 📝 `resources/lang/en/entities.php` (+1 -0) 📝 `resources/lang/en/errors.php` (+1 -0) 📝 `resources/views/pages/form.blade.php` (+11 -1) 📝 `routes/web.php` (+4 -1) 📝 `tests/BrowserKitTest.php` (+4 -5) 📝 `tests/ImageTest.php` (+110 -19) 📝 `tests/TestCase.php` (+6 -0) _...and 2 more files_ </details> ### 📄 Description Relates to #619. Very much a WIP at time of creating pull request. ### TODO - [x] Add updating of existing images. - [x] Implement within markdown editor. - [x] Add some basic testing to new endpoints. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:14:00 +03:00

OVERLORD closed this issue

2026-02-05 10:14:02 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5680