[PR #189] [MERGED] Laravel 5.3 upgrade #5610

New Issue

OVERLORD · 2026-02-05T10:12:13+03:00

OVERLORD commented

2026-02-05 10:12:13 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/189
Author: @ssddanbrown
Created: 9/13/2016
Status: ✅ Merged
Merged: 9/17/2016
Merged by: @ssddanbrown

Base: master ← Head: laravel_5.3_upgrade

📝 Commits (6)

20874ed Started move to laravel 5.3
b776a28 Started updating login & registration flows for laravel 5.3 update
39e81d9 Updated app emails to notification system
fbfc25f Fixed registations bugs and removed email confirmation model
8b9c38f Fixed large portion of laravel post-upgrade issues
74e9bc0 Fixed and tested LDAP process

📊 Changes

44 files changed (+1789 additions, -1100 deletions)

View changed files

📝 .gitignore (+2 -1)
➖ app/EmailConfirmation.php (+0 -16)
➖ app/Events/Event.php (+0 -8)
📝 app/Exceptions/Handler.php (+16 -0)
➕ app/Http/Controllers/Auth/ForgotPasswordController.php (+33 -0)
➕ app/Http/Controllers/Auth/LoginController.php (+123 -0)
📝 app/Http/Controllers/Auth/RegisterController.php (+68 -118)
📝 app/Http/Controllers/Auth/ResetPasswordController.php (+6 -5)
📝 app/Http/Controllers/Controller.php (+14 -9)
📝 app/Http/Kernel.php (+23 -5)
📝 app/Http/Middleware/Authenticate.php (+1 -1)
📝 app/Http/Middleware/RedirectIfAuthenticated.php (+2 -1)
➖ app/Jobs/Job.php (+0 -21)
➖ app/Listeners/.gitkeep (+0 -0)
➕ app/Notifications/ConfirmEmail.php (+48 -0)
➕ app/Notifications/ResetPassword.php (+50 -0)
➕ app/Providers/BroadcastServiceProvider.php (+26 -0)
📝 app/Providers/EventServiceProvider.php (+2 -5)
📝 app/Providers/PaginationServiceProvider.php (+7 -2)
📝 app/Providers/RouteServiceProvider.php (+38 -9)

...and 24 more files

📄 Description

Todo

Move current registration/confirmation/reset emails to use notification system.
Update the design of the notification emails to fit BookStack.
Test and update LDAP system.
Test and update remainder of the app.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/189 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 9/13/2016 **Status:** ✅ Merged **Merged:** 9/17/2016 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `laravel_5.3_upgrade` --- ### 📝 Commits (6) - [`20874ed`](https://github.com/BookStackApp/BookStack/commit/20874ed38f491144ecd031e8a28418ebb5107879) Started move to laravel 5.3 - [`b776a28`](https://github.com/BookStackApp/BookStack/commit/b776a288674a2564c03428cf1baab060bbba535b) Started updating login & registration flows for laravel 5.3 update - [`39e81d9`](https://github.com/BookStackApp/BookStack/commit/39e81d9a1ff23087689b1ef29d16937bbe5f8d1f) Updated app emails to notification system - [`fbfc25f`](https://github.com/BookStackApp/BookStack/commit/fbfc25fc217e8ddc46fca5eef469ce3bbda017f4) Fixed registations bugs and removed email confirmation model - [`8b9c38f`](https://github.com/BookStackApp/BookStack/commit/8b9c38fd3c167f3f0604d3e2dea0b140c8f6bd7c) Fixed large portion of laravel post-upgrade issues - [`74e9bc0`](https://github.com/BookStackApp/BookStack/commit/74e9bc0676f5355fd8e61e251b25c326c0506285) Fixed and tested LDAP process ### 📊 Changes **44 files changed** (+1789 additions, -1100 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -1) ➖ `app/EmailConfirmation.php` (+0 -16) ➖ `app/Events/Event.php` (+0 -8) 📝 `app/Exceptions/Handler.php` (+16 -0) ➕ `app/Http/Controllers/Auth/ForgotPasswordController.php` (+33 -0) ➕ `app/Http/Controllers/Auth/LoginController.php` (+123 -0) 📝 `app/Http/Controllers/Auth/RegisterController.php` (+68 -118) 📝 `app/Http/Controllers/Auth/ResetPasswordController.php` (+6 -5) 📝 `app/Http/Controllers/Controller.php` (+14 -9) 📝 `app/Http/Kernel.php` (+23 -5) 📝 `app/Http/Middleware/Authenticate.php` (+1 -1) 📝 `app/Http/Middleware/RedirectIfAuthenticated.php` (+2 -1) ➖ `app/Jobs/Job.php` (+0 -21) ➖ `app/Listeners/.gitkeep` (+0 -0) ➕ `app/Notifications/ConfirmEmail.php` (+48 -0) ➕ `app/Notifications/ResetPassword.php` (+50 -0) ➕ `app/Providers/BroadcastServiceProvider.php` (+26 -0) 📝 `app/Providers/EventServiceProvider.php` (+2 -5) 📝 `app/Providers/PaginationServiceProvider.php` (+7 -2) 📝 `app/Providers/RouteServiceProvider.php` (+38 -9) _...and 24 more files_ </details> ### 📄 Description ## Todo - [x] Move current registration/confirmation/reset emails to use notification system. - [x] Update the design of the notification emails to fit BookStack. - [x] Test and update LDAP system. - [x] Test and update remainder of the app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:12:13 +03:00

OVERLORD closed this issue

2026-02-05 10:12:16 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5610