[PR #176] [MERGED] Page link selector #5607

Closed
opened 2026-02-05 10:12:11 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/176
Author: @ssddanbrown
Created: 9/1/2016
Status: Merged
Merged: 9/3/2016
Merged by: @ssddanbrown

Base: masterHead: page_link_selector


📝 Commits (4)

  • 56df640 Updated popup design and started integrating link selector
  • 5b64358 Added link selector interface to WYSIWYG editor
  • 23e014c Added link selector to markdown editor
  • b14e9fc Fixed some cross browser flexbox popup issues

📊 Changes

15 files changed (+371 additions, -125 deletions)

View changed files

📝 resources/assets/js/controllers.js (+3 -1)
📝 resources/assets/js/directives.js (+118 -6)
📝 resources/assets/js/global.js (+26 -5)
📝 resources/assets/js/pages/page-form.js (+34 -14)
📝 resources/assets/sass/_buttons.scss (+10 -0)
📝 resources/assets/sass/_components.scss (+68 -29)
📝 resources/assets/sass/_grid.scss (+8 -0)
📝 resources/assets/sass/styles.scss (+1 -1)
📝 resources/views/books/list-item.blade.php (+1 -1)
📝 resources/views/chapters/list-item.blade.php (+2 -2)
📝 resources/views/pages/edit.blade.php (+8 -0)
📝 resources/views/pages/form.blade.php (+2 -0)
📝 resources/views/pages/list-item.blade.php (+1 -1)
resources/views/partials/entity-selector-popup.blade.php (+14 -0)
📝 resources/views/partials/image-manager.blade.php (+75 -65)

📄 Description

In reference to #105.

Todo:

  • Add link selector to markdown editor.
  • Test link selector and image selector in range of browsers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/176 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 9/1/2016 **Status:** ✅ Merged **Merged:** 9/3/2016 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `page_link_selector` --- ### 📝 Commits (4) - [`56df640`](https://github.com/BookStackApp/BookStack/commit/56df64063dcf46166e366ddf7e292b21a07e1003) Updated popup design and started integrating link selector - [`5b64358`](https://github.com/BookStackApp/BookStack/commit/5b64358ef1214bf7db6924f76b83f1b8fc088a43) Added link selector interface to WYSIWYG editor - [`23e014c`](https://github.com/BookStackApp/BookStack/commit/23e014cb25263aa20f21edd343704c88a3131fc6) Added link selector to markdown editor - [`b14e9fc`](https://github.com/BookStackApp/BookStack/commit/b14e9fc61950a4bc2709fe923dbf3ffbe7fc1463) Fixed some cross browser flexbox popup issues ### 📊 Changes **15 files changed** (+371 additions, -125 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/controllers.js` (+3 -1) 📝 `resources/assets/js/directives.js` (+118 -6) 📝 `resources/assets/js/global.js` (+26 -5) 📝 `resources/assets/js/pages/page-form.js` (+34 -14) 📝 `resources/assets/sass/_buttons.scss` (+10 -0) 📝 `resources/assets/sass/_components.scss` (+68 -29) 📝 `resources/assets/sass/_grid.scss` (+8 -0) 📝 `resources/assets/sass/styles.scss` (+1 -1) 📝 `resources/views/books/list-item.blade.php` (+1 -1) 📝 `resources/views/chapters/list-item.blade.php` (+2 -2) 📝 `resources/views/pages/edit.blade.php` (+8 -0) 📝 `resources/views/pages/form.blade.php` (+2 -0) 📝 `resources/views/pages/list-item.blade.php` (+1 -1) ➕ `resources/views/partials/entity-selector-popup.blade.php` (+14 -0) 📝 `resources/views/partials/image-manager.blade.php` (+75 -65) </details> ### 📄 Description In reference to #105. Todo: - [x] Add link selector to markdown editor. - [x] Test link selector and image selector in range of browsers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 10:12:11 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5607