[PR #110] [MERGED] Attribute System #5595

New Issue

OVERLORD · 2026-02-05T10:11:53+03:00

OVERLORD commented

2026-02-05 10:11:53 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/110
Author: @ssddanbrown
Created: 5/6/2016
Status: ✅ Merged
Merged: 5/15/2016
Merged by: @ssddanbrown

Base: master ← Head: page_attributes

📝 Commits (10+)

5080b49 Started base work on attribute system
c99653f Fixed bad refactor in the permission service
fcfb947 Added further attribute endpoints and added tests
1fa079b Started the page attributes interface
b80184c Renamed attribute to tags & continued interface
78564ec Cleaned up tag edit interface
7932069 Added tags to page display and simplified editing flow
8d80e73 Added tag searching to search interfaces
7ad28ae Updated travis file to hopefully fix CI errors
db2af47 Revert travis CI changes

📊 Changes

39 files changed (+1261 additions, -108 deletions)

View changed files

📝 .travis.yml (+0 -2)
📝 app/Entity.php (+61 -36)
📝 app/Http/Controllers/Controller.php (+11 -0)
📝 app/Http/Controllers/PageController.php (+1 -1)
➕ app/Http/Controllers/TagController.php (+74 -0)
📝 app/Http/routes.php (+10 -2)
📝 app/Repos/BookRepo.php (+3 -2)
📝 app/Repos/ChapterRepo.php (+3 -2)
📝 app/Repos/EntityRepo.php (+97 -1)
📝 app/Repos/PageRepo.php (+18 -3)
➕ app/Repos/TagRepo.php (+116 -0)
📝 app/Services/PermissionService.php (+13 -6)
➕ app/Tag.php (+19 -0)
📝 database/factories/ModelFactory.php (+7 -0)
➕ database/migrations/2016_05_06_185215_create_tags_table.php (+40 -0)
📝 package.json (+5 -4)
➕ public/libs/jquery/jquery-ui.min.js (+7 -0)
📝 resources/assets/js/controllers.js (+113 -1)
📝 resources/assets/js/directives.js (+215 -2)
📝 resources/assets/js/global.js (+2 -2)

...and 19 more files

📄 Description

As per #48. To be created as an AJAX-based system and controlled with angular in the page editor.
Attributes will only be able to be assigned to pages initially but future Chapter/Book support will be considered in build.

Build task list:

Initial API build
API testing in place
Angular-based UI on page editor screen
Attribute/value search support

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/110 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 5/6/2016 **Status:** ✅ Merged **Merged:** 5/15/2016 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `page_attributes` --- ### 📝 Commits (10+) - [`5080b49`](https://github.com/BookStackApp/BookStack/commit/5080b4996e32faed8d62f2625e2d310b432202e6) Started base work on attribute system - [`c99653f`](https://github.com/BookStackApp/BookStack/commit/c99653f0f2799a8adb73ab0ebc761c649debfb44) Fixed bad refactor in the permission service - [`fcfb947`](https://github.com/BookStackApp/BookStack/commit/fcfb9470c96c9bff054dbc28a7dea1d7b87ccb91) Added further attribute endpoints and added tests - [`1fa079b`](https://github.com/BookStackApp/BookStack/commit/1fa079b46626b5cbb3d1b055542e4a98b4b0ca0a) Started the page attributes interface - [`b80184c`](https://github.com/BookStackApp/BookStack/commit/b80184cd93d502ab2b4c0f21c1139842ca946057) Renamed attribute to tags & continued interface - [`78564ec`](https://github.com/BookStackApp/BookStack/commit/78564ec61dfe57ebb362eda21466ced6efaef276) Cleaned up tag edit interface - [`7932069`](https://github.com/BookStackApp/BookStack/commit/793206953500c24e9ec58b1feac8e7a256b92b1c) Added tags to page display and simplified editing flow - [`8d80e73`](https://github.com/BookStackApp/BookStack/commit/8d80e7311cf4166b5c9597dc793a8f53b13fd7f3) Added tag searching to search interfaces - [`7ad28ae`](https://github.com/BookStackApp/BookStack/commit/7ad28aeab4838e6365b0af1970f743871d95fe4d) Updated travis file to hopefully fix CI errors - [`db2af47`](https://github.com/BookStackApp/BookStack/commit/db2af47286200471ef21c0c9649c67c67d518e8b) Revert travis CI changes ### 📊 Changes **39 files changed** (+1261 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -2) 📝 `app/Entity.php` (+61 -36) 📝 `app/Http/Controllers/Controller.php` (+11 -0) 📝 `app/Http/Controllers/PageController.php` (+1 -1) ➕ `app/Http/Controllers/TagController.php` (+74 -0) 📝 `app/Http/routes.php` (+10 -2) 📝 `app/Repos/BookRepo.php` (+3 -2) 📝 `app/Repos/ChapterRepo.php` (+3 -2) 📝 `app/Repos/EntityRepo.php` (+97 -1) 📝 `app/Repos/PageRepo.php` (+18 -3) ➕ `app/Repos/TagRepo.php` (+116 -0) 📝 `app/Services/PermissionService.php` (+13 -6) ➕ `app/Tag.php` (+19 -0) 📝 `database/factories/ModelFactory.php` (+7 -0) ➕ `database/migrations/2016_05_06_185215_create_tags_table.php` (+40 -0) 📝 `package.json` (+5 -4) ➕ `public/libs/jquery/jquery-ui.min.js` (+7 -0) 📝 `resources/assets/js/controllers.js` (+113 -1) 📝 `resources/assets/js/directives.js` (+215 -2) 📝 `resources/assets/js/global.js` (+2 -2) _...and 19 more files_ </details> ### 📄 Description As per #48. To be created as an AJAX-based system and controlled with angular in the page editor. Attributes will only be able to be assigned to pages initially but future Chapter/Book support will be considered in build. ### Build task list: - [x] Initial API build - [x] API testing in place - [x] Angular-based UI on page editor screen - [x] Attribute/value search support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:11:53 +03:00

OVERLORD closed this issue

2026-02-05 10:11:55 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5595