[PR #84] [MERGED] Implementation of a markdown editor #5594

New Issue

OVERLORD · 2026-02-05T10:11:51+03:00

OVERLORD commented

2026-02-05 10:11:51 +03:00

📋 Pull Request Information

Original PR: https://github.com/BookStackApp/BookStack/pull/84
Author: @ssddanbrown
Created: 3/25/2016
Status: ✅ Merged
Merged: 3/29/2016
Merged by: @ssddanbrown

Base: master ← Head: markdown_editor

📝 Commits (4)

26965fa Added a markdown editor
efb4901 Integrated the markdown editor with the image manager
e1994ef Added editor control in admin settings & Fixed some markdown editor bugs
dc29788 Added basic system tests for markdown editor, Added extra test helpers

📊 Changes

21 files changed (+391 additions, -35 deletions)

View changed files

📝 app/Http/Controllers/PageController.php (+3 -2)
📝 app/Page.php (+1 -1)
📝 app/PageRevision.php (+1 -1)
📝 app/Repos/PageRepo.php (+4 -0)
📝 app/Services/SettingService.php (+12 -1)
📝 config/app.php (+2 -0)
➕ config/setting-defaults.php (+10 -0)
➕ database/migrations/2016_03_25_123157_add_markdown_support.php (+39 -0)
📝 package.json (+1 -0)
➕ public/fonts/roboto-mono-v4-latin-regular.woff (+0 -0)
➕ public/fonts/roboto-mono-v4-latin-regular.woff2 (+0 -0)
📝 readme.md (+1 -0)
📝 resources/assets/js/controllers.js (+33 -14)
📝 resources/assets/js/directives.js (+77 -1)
📝 resources/assets/sass/_fonts.scss (+11 -0)
📝 resources/assets/sass/_forms.scss (+57 -0)
📝 resources/assets/sass/_text.scss (+6 -0)
📝 resources/views/pages/form.blade.php (+40 -5)
📝 resources/views/settings/index.blade.php (+18 -10)
➕ tests/Entity/MarkdownTest.php (+51 -0)

...and 1 more files

📄 Description

Basic initial implementation of a markdown editor as requested on #57.

Todo

Create a markdown editor interface.
Add markdown support to pages and page revisions.
Integrate the markdown editor with the image manager.
Allow changing the editor type via the Admin UI (currently done via the .env file).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/BookStackApp/BookStack/pull/84 **Author:** [@ssddanbrown](https://github.com/ssddanbrown) **Created:** 3/25/2016 **Status:** ✅ Merged **Merged:** 3/29/2016 **Merged by:** [@ssddanbrown](https://github.com/ssddanbrown) **Base:** `master` ← **Head:** `markdown_editor` --- ### 📝 Commits (4) - [`26965fa`](https://github.com/BookStackApp/BookStack/commit/26965fa08f8a5e834b01f743109c835a62724706) Added a markdown editor - [`efb4901`](https://github.com/BookStackApp/BookStack/commit/efb49019d484f2455897d2249e16ccd0b2ad5e88) Integrated the markdown editor with the image manager - [`e1994ef`](https://github.com/BookStackApp/BookStack/commit/e1994ef2cf6552516888422063cf859586f0de14) Added editor control in admin settings & Fixed some markdown editor bugs - [`dc29788`](https://github.com/BookStackApp/BookStack/commit/dc2978824ee9a783402e4c28934965f5dcffeb0a) Added basic system tests for markdown editor, Added extra test helpers ### 📊 Changes **21 files changed** (+391 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/PageController.php` (+3 -2) 📝 `app/Page.php` (+1 -1) 📝 `app/PageRevision.php` (+1 -1) 📝 `app/Repos/PageRepo.php` (+4 -0) 📝 `app/Services/SettingService.php` (+12 -1) 📝 `config/app.php` (+2 -0) ➕ `config/setting-defaults.php` (+10 -0) ➕ `database/migrations/2016_03_25_123157_add_markdown_support.php` (+39 -0) 📝 `package.json` (+1 -0) ➕ `public/fonts/roboto-mono-v4-latin-regular.woff` (+0 -0) ➕ `public/fonts/roboto-mono-v4-latin-regular.woff2` (+0 -0) 📝 `readme.md` (+1 -0) 📝 `resources/assets/js/controllers.js` (+33 -14) 📝 `resources/assets/js/directives.js` (+77 -1) 📝 `resources/assets/sass/_fonts.scss` (+11 -0) 📝 `resources/assets/sass/_forms.scss` (+57 -0) 📝 `resources/assets/sass/_text.scss` (+6 -0) 📝 `resources/views/pages/form.blade.php` (+40 -5) 📝 `resources/views/settings/index.blade.php` (+18 -10) ➕ `tests/Entity/MarkdownTest.php` (+51 -0) _...and 1 more files_ </details> ### 📄 Description Basic initial implementation of a markdown editor as requested on #57. **Todo** - [x] Create a markdown editor interface. - [x] Add markdown support to pages and page revisions. - [x] Integrate the markdown editor with the image manager. - [x] Allow changing the editor type via the Admin UI _(currently done via the .env file)_. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-05 10:11:51 +03:00

OVERLORD closed this issue

2026-02-05 10:11:53 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#5594