mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 19:06:16 +03:00
Slack Requires Authorization At Every Login. #544
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @obeardly on GitHub (Jan 10, 2018).
For Bug Reports
Expected Behavior
When logging in with Slack, I expect Bookstack to ask for authorization once, and then retain the ability to login without reauthorizing.
Current Behavior
When logging in with Slack, it asks me to authorize the app every time.
Steps to Reproduce
With the aforementioned versions of BookStack, PHP, and MySQL, enable Slack login and attempt to login more than once. Requires you to reauthorize at every login.
@ssddanbrown commented on GitHub (Jan 10, 2018):
Can confirm this but I've had a good dig into and and cannot find why this happens. Pretty sure it's some sort of change on slack's side but cannot work out why or what. BookStack appears to construct the auth URL as expected.
Have you noticed this for a while? Wondering if it's a temporary problem on slack's side.
@ssddanbrown commented on GitHub (Jan 10, 2018):
Just tried on another, Non-BookStack-related, app I manually set up slack auth on. Does that same thing.
@obeardly commented on GitHub (Jan 11, 2018):
It has done this since I installed. In the past, I have used Slack for
authentication on other apps, and it did not do this. However, as you said,
this may be a change on Slack's end. I'll look further into it.
On Wed, Jan 10, 2018 at 3:34 PM, Dan Brown notifications@github.com wrote:
@shane-smith commented on GitHub (Feb 27, 2018):
Maybe this is relevant?
https://stackoverflow.com/questions/46094760/sign-in-with-slack-keeps-prompting-user-for-permission-every-time
@obeardly commented on GitHub (Feb 27, 2018):
That definitely seems relevant. The question is now, how do we enable cookies in BookStack?
@ssddanbrown commented on GitHub (Nov 15, 2021):
Just re-reviewing this, based upon the response from slack in this stackoverflow question it appears the above text was an incorrect detail in the documentation.
I don't think there's anything we can do about this so I'll close this off.
Note, Slack now advise using their more recent OIDC for authentication flow, which we now support as a primary authentication mechanism. I'd imagine this would not have this issue.