mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-05-04 18:08:46 +03:00
On a laptop with a screen of 768px height I can't see "Save code" button in the code editor. #535
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mrEvgenX on GitHub (Dec 31, 2017).
Expected Behavior
When I'm finishing edit code in "code block" popup window I'd like to see save button.
Current Behavior (as clear as possible now)
When I'm seeing a page it's okay
When I'm editing the page I choose "Code block"
Finally in the popup window to edit the code a laptop has not enough height to display the button "save code".
Also code-preview doesn't work in edit-page mode (gray rectangle on the screenshot below).
Steps to Reproduce
Reproducible on devices with low height
@cthoennessen commented on GitHub (Jan 5, 2018):
Thank you so much for mentioning this issue here! I almost desperated about how to save the code. After reading this I zoomed out and suprise, there is a secret save button! 😄
@Abijeet commented on GitHub (Jan 5, 2018):
I guess adding a scroll-bar to the modal will be an acceptable solution.
@Abijeet commented on GitHub (Jan 5, 2018):
Although adding a scroll-bar to the modal although is a fairly simple solution, it causes two scroll-bars to appear on the popup if the content in the code editor is more.
@ssddanbrown - Any ideas?
@Shackelford-Arden commented on GitHub (Jan 5, 2018):
Just a thought here... Would it be possible to move the save button to right underneath the X or to the left of it on smaller screens? @Abijeet
@Abijeet commented on GitHub (Jan 6, 2018):
@Shackelford-Arden - Not sure, following images are taken on a Google Nexus 5 and 4, below the X is not an option.
Regarding putting it to the left of the close icon, it would be different then rest of the dialogs in BookStack.
@ssddanbrown - I think we currently have 4 dialogs in BookStack,
Insert image (2) is unique, it makes sense the way it is right now. 1 and 3 have a section at the bottom with OK and cancel buttons and I think 4 should also be similar. I know this is deviating of the topic but if we're going to be working on this issue we might as well deal with this inconsistency now.
Regarding the save button not visible issue, I've submitted a PR - #654 that adds a scroll bar if the content is too big for the screen.
@Shackelford-Arden commented on GitHub (Jan 7, 2018):
I wish I knew enough to help more!