mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 11:19:38 +03:00
%prettyVersion%.zip in composer.lock | NixOS Build failing for v25.02.1
#5242
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @HritwikSinghal on GitHub (Mar 29, 2025).
Describe the Bug
Hi, when looking at composer.lock on the development branch, i can see 2 packages (
htmlDiffandasserthtml) having%prettyVersion%.zipin their url. (see htmlDiff and assertHtml ) .the correct url should be like
https://codeberg.org/api/v1/repos/danb/asserthtml/archive/master.zip(emphasis on master.zip instead of %prettyVersion%.zip), something similar to codeberg API from here which clearly statesthe git reference for download with attached archive format (e.g. master.zip)for thearchiveargument.is this intentional because these url's look inconsistent with the rest of the url's in file. (i am no expert in php tho). The nixos build is failing due to this.
just by replacing these url's with
main, thus the path becomesmain.zip, the build is fixed.BROKEN URL:
https://codeberg.org/api/v1/repos/danb/HtmlDiff/archive/%prettyVersion%.zipCORRECT URL:
https://codeberg.org/api/v1/repos/danb/HtmlDiff/archive/main.zipSteps to Reproduce
Expected Behaviour
Bookstack should compile.
Screenshots or Additional Context
URL for htmlDiff package
URL for assertHTML package
Exact BookStack Version
v25.02.1
Temporary Resolution ( if any )
BROKEN URL:
https://codeberg.org/api/v1/repos/danb/HtmlDiff/archive/%prettyVersion%.zipCORRECT URL:
https://codeberg.org/api/v1/repos/danb/HtmlDiff/archive/main.zipreplaced the
%prettyVersion%in composer.lock withmainto fix the nixos Build. see@HritwikSinghal commented on GitHub (Mar 29, 2025):
this bug was introduced in
01825ddb93commit@HritwikSinghal commented on GitHub (Mar 29, 2025):
My question is: is having
%prettyVersion%.zipin the url's expected behaviour?if so why (i am a noob in php tho).
if not, what should be done to properly fix this. is this not causing any issues with tests?
@ssddanbrown commented on GitHub (Mar 30, 2025):
Hi @HritwikSinghal,
%prettyVersion%is expected, and makes use of a composer feature to resolve a full actual URL for ZIP download.The correct replacement is not
mainbut the version reference for the package withincomposer.lock.This is used as a workaround in my Codeberg packages to provide ZIP-download support since otherwise this is not automatically handled by composer/packagist, leaving Codeberg packages to use git download instead of download via ZIP.
I only really consider composer support for our
compose.lockfile, I don't consider other external systems like whatever NixOS is doing.If it helps, I recently introduced a new alternative non-composer process for fetching PHP dependencies:
https://www.bookstackapp.com/blog/php-dependency-improvements/
@HritwikSinghal commented on GitHub (Mar 30, 2025):
ah, thanks for the clarification. Will close this issue 👍 .