mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 03:12:20 +03:00
PDF gets always downloaded #5212
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bombobama on GitHub (Mar 7, 2025).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
Hello,
I uploaded a PDF as attachment and created a link to open it in a new tab.
The problem is that the PDF always gets downloaded and doesn't open inline.
This occurs with Chrome, Edge and Firefox only for Firefox it opens in new tab after downloading.
I already checked browser settings, and webserver configuration. I haven't found a way to get the attachments to open inline.
Am i missing something? Can someone help me?
Thank you
Exact BookStack Version
v24.12.1
Log Content
No response
Hosting Environment
php 8.2, SLES15-SP6, apache2
@ssddanbrown commented on GitHub (Mar 7, 2025):
Hi @bombobama,
Are you using the attachment link gained via the "Open in Tab" option as displayed here?:
This is just a normal attachment link, with
?open=trueadded to the end.This should allow it to be opened inline (If detected as an allowed file format, which PDF should be).
@bombobama commented on GitHub (Mar 11, 2025):
Hi @ssddanbrown thank you for responsing,
what you showed works, but that's not what I meant. I was talking about embedding an attachment as a link in a text and then clicking on that link to open it in a new tab. When I do that, it always gets downloaded. A simple attachment link like this:
@ssddanbrown commented on GitHub (Mar 11, 2025):
@bombobama That "Open in Tab" button is just a normal link also.
How exactly is your link configured? What is the URL used?
@bombobama commented on GitHub (Mar 12, 2025):
I uploaded the pdf as attachment and inserted this attachment as a link on a page. URL looks like this: https://example-site/bookstack/attachments/7)
I just checked the URLs again and saw that for "open in tab" the URL ends with "?open=true", which is not the case for the embedded link on the page.
However, I did not see an option for this here:
I can manually edit the link to get the wanted result, but I would say this is not really intuitive for standard users. Maybe i am missing something?
@ssddanbrown commented on GitHub (Mar 12, 2025):
Yeah, there's no option on the attachment edit form itself.
You do just manually edit the link to append the open part (or copy the "Open in Tab" link originally and insert that).
@bombobama commented on GitHub (Mar 12, 2025):
Ok, thank you you very much! Maybe this could be added in future.