starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-12 19:06:27 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

parametrized activity i18n #5069

New Issue
Open
opened 2026-02-05 09:37:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 09:37:58 +03:00
Owner
Copy Link

Originally created by @kekcsi on GitHub (Nov 30, 2024).

Describe the Bug

Translation keys like page_create, page_update, chapter_create should be parametrized like':user created page :entity'- otherwise grammatically correct sentences can't be constructed in languages other than English.

Steps to Reproduce

  1. Switch the UI to Hungarian, maybe using the browser's preferred language setting.
  2. Reload any BookStack page.
  3. Scroll down on the left sidebar. See that the activities are written in a weird Yoda language.

Expected Behaviour

Some languages would have a word or two AFTER the page title or BEFORE user name in the activities displayed.

Screenshots or Additional Context

image

Browser Details

No response

Exact BookStack Version

24.05.4

Originally created by @kekcsi on GitHub (Nov 30, 2024). ### Describe the Bug Translation keys like `page_create`, `page_update`, `chapter_create `should be parametrized like` ':user created page :entity' `- otherwise grammatically correct sentences can't be constructed in languages other than English. ### Steps to Reproduce 1. Switch the UI to Hungarian, maybe using the browser's preferred language setting. 2. Reload any BookStack page. 3. Scroll down on the left sidebar. See that the activities are written in a weird Yoda language. ### Expected Behaviour Some languages would have a word or two AFTER the page title or BEFORE user name in the activities displayed. ### Screenshots or Additional Context ![image](https://github.com/user-attachments/assets/cb7e1e56-ed39-48bc-92b0-66922708c00f) ### Browser Details _No response_ ### Exact BookStack Version 24.05.4
OVERLORD added the 🛠️ Enhancement💆 UX🌍 Translations labels 2026-02-05 09:37:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 🌍 Translations 🛠️ Enhancement 💆 UX
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5069
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?