starred/BookStack
1
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2026-02-06 19:06:02 +03:00
Code Issues 784 Packages Projects Releases 10 Wiki Activity

Failed include handling & content parsing on PHP 8.3 #5066

New Issue
Closed
opened 2026-02-05 09:37:48 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 09:37:48 +03:00
Owner
Copy Link

Originally created by @ssddanbrown on GitHub (Nov 27, 2024).

Seems to be a recent issue, started to appear in tests.
Occurs on my dev instance using 8.3.14.
Occurs in actual use too, not just tests.

Need to understand when this started, why, and if the issue is with our code or a PHP bug.

Error detail

Details 

Call to a member function importNode() on null
Stack Trace

#0 /home/dan/web/bookstack/app/Entities/Tools/PageIncludeParser.php(56): BookStack\Entities\Tools\PageIncludeParser->replaceNodeWithNodes()
#1 /home/dan/web/bookstack/app/Entities/Tools/PageContent.php(310): BookStack\Entities\Tools\PageIncludeParser->parse()
#2 /home/dan/web/bookstack/app/Entities/Controllers/PageController.php(153): BookStack\Entities\Tools\PageContent->render()
#3 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): BookStack\Entities\Controllers\PageController->show()
#4 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(43): Illuminate\Routing\Controller->callAction()
#5 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(259): Illuminate\Routing\ControllerDispatcher->dispatch()
#6 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(205): Illuminate\Routing\Route->runController()
#7 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(806): Illuminate\Routing\Route->run()
#8 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\Routing\Router->Illuminate\Routing\{closure}()
#9 /home/dan/web/bookstack/app/Http/Middleware/Authenticate.php(23): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#10 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\Authenticate->handle()
#11 /home/dan/web/bookstack/app/Http/Middleware/Localization.php(32): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#12 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\Localization->handle()
#13 /home/dan/web/bookstack/app/Http/Middleware/RunThemeActions.php(26): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#14 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\RunThemeActions->handle()
#15 /home/dan/web/bookstack/app/Http/Middleware/CheckEmailConfirmed.php(47): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#16 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\CheckEmailConfirmed->handle()
#17 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(78): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#18 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle()
#19 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()

Reduced Example Case

https://3v4l.org/BQFa7

Originally created by @ssddanbrown on GitHub (Nov 27, 2024). Seems to be a recent issue, started to appear in tests. Occurs on my dev instance using `8.3.14`. Occurs in actual use too, not just tests. Need to understand when this started, why, and if the issue is with our code or a PHP bug. ### Error detail <details><summary>Details</summary> <p> ``` Call to a member function importNode() on null Stack Trace #0 /home/dan/web/bookstack/app/Entities/Tools/PageIncludeParser.php(56): BookStack\Entities\Tools\PageIncludeParser->replaceNodeWithNodes() #1 /home/dan/web/bookstack/app/Entities/Tools/PageContent.php(310): BookStack\Entities\Tools\PageIncludeParser->parse() #2 /home/dan/web/bookstack/app/Entities/Controllers/PageController.php(153): BookStack\Entities\Tools\PageContent->render() #3 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): BookStack\Entities\Controllers\PageController->show() #4 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(43): Illuminate\Routing\Controller->callAction() #5 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(259): Illuminate\Routing\ControllerDispatcher->dispatch() #6 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(205): Illuminate\Routing\Route->runController() #7 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(806): Illuminate\Routing\Route->run() #8 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\Routing\Router->Illuminate\Routing\{closure}() #9 /home/dan/web/bookstack/app/Http/Middleware/Authenticate.php(23): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() #10 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\Authenticate->handle() #11 /home/dan/web/bookstack/app/Http/Middleware/Localization.php(32): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() #12 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\Localization->handle() #13 /home/dan/web/bookstack/app/Http/Middleware/RunThemeActions.php(26): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() #14 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\RunThemeActions->handle() #15 /home/dan/web/bookstack/app/Http/Middleware/CheckEmailConfirmed.php(47): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() #16 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): BookStack\Http\Middleware\CheckEmailConfirmed->handle() #17 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(78): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() #18 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle() #19 /home/dan/web/bookstack/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}() ``` </p> </details> ### Reduced Example Case https://3v4l.org/BQFa7
OVERLORD added the 🔧 Maintenance🐛 Bug🏭 Back-End labels 2026-02-05 09:37:48 +03:00
OVERLORD commented 2026-02-05 09:37:50 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Nov 27, 2024):

Only occurs on PHP 8.3.14.
Potentially a PHP bug, have raised here: https://github.com/php/php-src/issues/16967
Is something we can easily work around though, so something we can add into a patch release for PHP 8.3.14 users.

@ssddanbrown commented on GitHub (Nov 27, 2024): Only occurs on PHP 8.3.14. Potentially a PHP bug, have raised here: https://github.com/php/php-src/issues/16967 Is something we can easily work around though, so something we can add into a patch release for PHP 8.3.14 users.
OVERLORD commented 2026-02-05 09:37:53 +03:00
Author
Owner
Copy Link

@ssddanbrown commented on GitHub (Nov 27, 2024):

Due to be addressed in PHP 8.3.15, reference: https://github.com/php/php-src/issues/16967#issuecomment-2504519751

@ssddanbrown commented on GitHub (Nov 27, 2024): Due to be addressed in PHP 8.3.15, reference: https://github.com/php/php-src/issues/16967#issuecomment-2504519751
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label 🐛 Bug 🏭 Back-End 🔧 Maintenance
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#5066
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?