mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-16 19:06:45 +03:00
file:// attachment links not stored like http:// and https://
#5050
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @haydenkwelsh on GitHub (Nov 14, 2024).
Describe the Bug
When a
http://orhttps://attachment link is created ...... it will be stored by Bookstack ...
... which makes updating a link used multiple times in a document easy, as you only have to change it once in the "Attachments" side menu.
On the other hand, when a
file://attachment link is created ...... it is NOT stored by Bookstack ...
... which makes updating a link used multiple times in a document very tedious.
Apologies if this is behaviour has a sound reason behind it, but it seems like Bookstack storing all attachment links would be helpful and provide consistency.
Steps to Reproduce
http://orhttps://.file://.Expected Behaviour
All links (starting with
http://,https://,file://, etc) added to a document's "Attachments" will be stored by Bookstack for ease of future link editing. Some may not be stored due to potential validation checks, but such failures should be indicated to the end user in the form of a pop-up or other sensible method.Screenshots or Additional Context
See screenshots taken above.
This is somewhat related to these other issues:
Browser Details
n/a
Exact BookStack Version
v24.02
@ssddanbrown commented on GitHub (Nov 14, 2024):
Hi @haydenkwelsh,
From what I remember, we show/expose non http(s) links directly since we can't reliable be sure that other links types are going to function via the dynamic redirect mechanism that's in place for http(s) links.
Especially so with file links which are often blocked in various ways in modern browsers.
@ssddanbrown commented on GitHub (Nov 28, 2024):
Since there's been no further follow-up, and I don't see an alternative better option, I'll go ahead and close this off.