mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-11 19:06:22 +03:00
No message when user has no right to delete attachment #5049
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JtheBAB on GitHub (Nov 14, 2024).
Describe the Bug
A user complained that he edited a page and wanted to delete an attachment. He clicked on the delete button for the attachment, confirm it but nothing happen. It turned out that the permission setting in the group was "own". Changing to "all" and he could delete the attachment in question. I guess the attachment was uploaded by another person.
Steps to Reproduce
Check that the group setting for attachment is "onw".
Edit a page as user A and upload an attachment
Save it
Edit the page as user B and try to delete the attachment. You can confirm the deletion but the attachment is still there.
Expected Behaviour
Bookstack should provide a message why that attachment can't be deleted.
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
v24.10.2
@ssddanbrown commented on GitHub (Nov 14, 2024):
Thanks @JtheBAB for reporting.
Ultimately, the user shouldn't be provided the option in the first place if they don't have the permissions to perform the action.
I've assigned to be addressed for the next feature release.
@ssddanbrown commented on GitHub (Dec 11, 2024):
This has now been addressed in
fcf0bf79a9, so that controls are not shown if the user does not have permission to use them. This will be part of the next feature release.Thanks again for reporting @JtheBAB.