mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-20 19:07:02 +03:00
Improve error handling of synchronous notifications #5045
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Nov 11, 2024).
Notification email sending failures, without using a queue/worker currently throw and block the process, showing the error view.
Since email requires the network, and SMTP servers can respond in various unexpected ways, and since notifications sending issues probably wouldn't be considered an essential error to the majority of cases, would should probably instead attempt these but catch & log errors, to allow the action within BookStack to continue as expected.
Related to support thread 125
Doc Updates
Probably worth documenting error behaviour on the docs page.