mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
Add theme category in settings page #4993
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LachTrip on GitHub (Oct 10, 2024).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
Trying to make an additional settings page for my bookstack theme. I can add a new category to settings.layout and have a custom settings page, but to be able to access it I need to add an entry to the settingCategories in app/Settings/SettingController.php, which does not seem possible through current theming options.
Exact BookStack Version
v24.03-dev
Log Content
No response
Hosting Environment
Debian docker
@ssddanbrown commented on GitHub (Oct 10, 2024):
Hi @LachTrip,
Yeah, the categories are not made customizable in any way.
I guess we could change this up so, instead of validating the categories by fixed array, we could validate them by checking for an existing matching view file. Would probably be best to move the existing setting category layouts into their own view folder though to prevent any pollution in that respect.
@ssddanbrown commented on GitHub (Oct 11, 2024):
Now achieved via your PR #5255, thanks again @LachTrip!