Bug: Reordering attachments breaks ability to drag attachment link into edited page #499

Closed
opened 2026-02-04 20:35:03 +03:00 by OVERLORD · 3 comments
Owner

Originally created by @Wookbert on GitHub (Nov 13, 2017).

  • BookStack Version 0.18 (on Demo Site)
  • Observed on Mac OS High Sierra 10.13.1, Chrome Version 62.0.3202.89

In Edit mode: Dragging an attachment into the page, creates link in the current paragraph to that attachment. So far, so good...

However: If one grabs the reorder attachments icon and moves it to reorder (regardless whether there is one or multiple attachments), dragging the attachment itself into the page is no longer possible. In other words: Reordering breaks the ability to drag the attachment link into the page.

Workaround: Save the page first, then enter Edit mode again, and dragging attachment to create link works again.

Video with bug in screen recording session:
https://www.youtube.com/watch?v=_N78tA0eq2k

Originally created by @Wookbert on GitHub (Nov 13, 2017). * BookStack Version 0.18 (on Demo Site) * Observed on Mac OS High Sierra 10.13.1, Chrome Version 62.0.3202.89 In Edit mode: Dragging an attachment into the page, creates link in the current paragraph to that attachment. So far, so good... However: If one grabs the _reorder attachments icon_ and moves it to reorder (regardless whether there is one or multiple attachments), dragging the attachment itself into the page is no longer possible. In other words: Reordering breaks the ability to drag the attachment link into the page. Workaround: Save the page first, then enter Edit mode again, and dragging attachment to create link works again. Video with bug in screen recording session: https://www.youtube.com/watch?v=_N78tA0eq2k
OVERLORD added the 🛠️ Enhancement🐛 Bug labels 2026-02-04 20:35:03 +03:00
Author
Owner

@ssddanbrown commented on GitHub (Nov 19, 2017):

Thank for reporting but I must admit, Did not even realise this was possible.

Will have a look as to how/why this occurs.

@ssddanbrown commented on GitHub (Nov 19, 2017): Thank for reporting but I must admit, Did not even realise this was possible. Will have a look as to how/why this occurs.
Author
Owner

@Wookbert commented on GitHub (Nov 19, 2017):

The ability to drag & drop attachments into the Wiki page is really essential when sharing/collaborating with multiple users and having more than let's say three attachments which you need to refer to in the text. The ability to simply click onto the attachment IN THE TEXT, rather than manually searching the referred file in the list of the attachments, avoids possible confusion and saves a lot of time.

Best,
André

On 19.11.2017, at 17:00, Dan Brown notifications@github.com wrote:

Thank for reporting but I must admit, Did not even realise this was possible.

Will have a look as to how/why this occurs.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@Wookbert commented on GitHub (Nov 19, 2017): The ability to drag & drop attachments into the Wiki page is really essential when sharing/collaborating with multiple users and having more than let's say three attachments which you need to refer to in the text. The ability to simply click onto the attachment IN THE TEXT, rather than manually searching the referred file in the list of the attachments, avoids possible confusion and saves a lot of time. Best, André > On 19.11.2017, at 17:00, Dan Brown <notifications@github.com> wrote: > > Thank for reporting but I must admit, Did not even realise this was possible. > > Will have a look as to how/why this occurs. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread. >
Author
Owner

@ssddanbrown commented on GitHub (May 22, 2023):

Apologies for the lack of response on this one for the past half a decade 😨
Just came across this while reviewing outstanding bugs.

At some point I did add proper dedicated drag and drop handling via dragging using the handle, and via a button on the attachment card.
Coming back to this now, I've extended the drag and drop handling so that the link/name of the attachment is also a drag "handle" so drop usage as per your video would now be managed via our dedicated handling.
I added that in e591f4896e, and it will be part of the next patch release.

@ssddanbrown commented on GitHub (May 22, 2023): Apologies for the lack of response on this one for the past half a decade :fearful: Just came across this while reviewing outstanding bugs. At some point I did add proper dedicated drag and drop handling via dragging using the handle, and via a button on the attachment card. Coming back to this now, I've extended the drag and drop handling so that the link/name of the attachment is also a drag "handle" so drop usage as per your video would now be managed via our dedicated handling. I added that in e591f4896e80acf118f656dfb3dece80ff9b6b07, and it will be part of the next patch release.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#499