test_gif_thumbnail_generation fails after release #4954

New Issue

OVERLORD · 2026-02-05T09:29:10+03:00

OVERLORD commented

2026-02-05 09:29:10 +03:00

Originally created by @ramel-contria on GitHub (Sep 19, 2024).

Describe the Bug

Since the latest release of BookStack, the test_gif_thumbnail_generation test fails and returns the following:

1) Tests\Uploads\ImageTest::test_gif_thumbnail_generation
Failed asserting that 2 matches expected 1.

I think it might be a dependancy through composer install that makes the test fail.

Steps to Reproduce

git pull origin release
composer install
php artisan migrate --database=mysql_testing
php artisan db:seed --class=DummyContentSeeder --database=mysql_testing
php vendor/bin/phpunit --filter test_gif_thumbnail_generation

Expected Behaviour

Expected would be that the test would not fail.

Screenshots or Additional Context

We are currently planning on using BookStack for our company to use as a know-how tool, and are adding some custom code through the theming functionality. For this, we use the release branch as a base and not the developent, since we do not want yet to be supported functions on our end. During our pipelines, we test next to our own tests the regular tests aswell, and this is where we noticed the problem with the test.

Browser Details

No response

Exact BookStack Version

v.24.05.4

Originally created by @ramel-contria on GitHub (Sep 19, 2024). ### Describe the Bug Since the latest release of BookStack, the test_gif_thumbnail_generation test fails and returns the following: ``` 1) Tests\Uploads\ImageTest::test_gif_thumbnail_generation Failed asserting that 2 matches expected 1. ``` I think it might be a dependancy through `composer install` that makes the test fail. ### Steps to Reproduce 1. `git pull origin release` 2. `composer install` 3. `php artisan migrate --database=mysql_testing` 4. `php artisan db:seed --class=DummyContentSeeder --database=mysql_testing` 5. `php vendor/bin/phpunit --filter test_gif_thumbnail_generation` ### Expected Behaviour Expected would be that the test would not fail. ### Screenshots or Additional Context We are currently planning on using BookStack for our company to use as a know-how tool, and are adding some custom code through the theming functionality. For this, we use the release branch as a base and not the developent, since we do not want yet to be supported functions on our end. During our pipelines, we test next to our own tests the regular tests aswell, and this is where we noticed the problem with the test. ### Browser Details _No response_ ### Exact BookStack Version v.24.05.4

OVERLORD added the 🐛 Bug label 2026-02-05 09:29:10 +03:00

OVERLORD closed this issue

2026-02-05 09:29:11 +03:00

OVERLORD commented

2026-02-05 09:29:14 +03:00

@ssddanbrown commented on GitHub (Sep 27, 2024):

Hi @ramel-contria,
The problem seems resolved in development now, maybe due to dependency (project or system) updates.

Just a warning I can't assure that tests will always pass in all environments in development or release.
Sometimes releases will go out with failing tests, where those tests can pass in other environments and/or where the test may not be important enough to delay release.

If this test continues to fail, feel free to provide extra context/info about what you may find the underlying issue to be, and/or suggestions to make the test more reliable in general.

@ssddanbrown commented on GitHub (Sep 27, 2024): Hi @ramel-contria, The problem seems resolved in `development` now, maybe due to dependency (project or system) updates. Just a warning I can't assure that tests will always pass in all environments in development or release. Sometimes releases will go out with failing tests, where those tests can pass in other environments and/or where the test may not be important enough to delay release. If this test continues to fail, feel free to provide extra context/info about what you may find the underlying issue to be, and/or suggestions to make the test more reliable in general.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#4954