mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 19:06:05 +03:00
Single apostrophes and quotes change search behaviour #4924
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @matthias4217 on GitHub (Aug 23, 2024).
Describe the Bug
When searching for
Subject's terms(using an apostropheU+0027, for instance,termswill be added to the search terms input, whileSubject'swill go in the exact terms one.The same happens when using quotes (
"U+0022), but not when using the right single quotation mark (’U+2019).Steps to Reproduce
Use a single apostrophe or a quote in a search.
Expected Behaviour
If using a single quote, I think it would be better to internally escape it and not treat it as a delimiter for an exact search term. When more than one are used though, it seems fair that they are treated as delimiters of an exact search term.
Screenshots or Additional Context
It’s not a big deal, but it might be good to at least document the behaviour of single quotes or apostrophes.
Browser Details
No response
Exact BookStack Version
v24.05.2 (with some slight modifications, though not on the search)