mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-13 03:13:58 +03:00
Safari downloads as .dms files. #490
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dansherman on GitHub (Nov 2, 2017).
Originally assigned to: @ssddanbrown on GitHub.
For Bug Reports
Expected Behavior
Exports should be downloaded with the correct file extension (.pdf, .html, .txt)
Current Behavior
Exports download as page.dms, html.dms, or plaintext.dms when using Safari Version 11.0 (12604.1.38.1.7). If I change the extension after the file is downloaded, it opens correctly.
It also exports correctly using Chrome.
Steps to Reproduce
Install using the Ubuntu 16.04 script.
Create a new book/page.
Click any of the export links.
@ssddanbrown commented on GitHub (Nov 11, 2017):
Was hoping I could replicate this on an iPad but I unfortunately cannot.
Interestingly, Looking at this page it appears this could be down to a bug in safari.
This could probably be worked-around by adding file extensions to the export urls but that has a chance of causing issues where different server rules have be set up for static file types.
Think the best course of action here is to wait for apple to fix safari unless anyone can confirm it is a BookStack issue.
@tomasjay commented on GitHub (Aug 11, 2018):
@ssddanbrown: Hi Dan, I can confirm that the issue still exists when using Safari on a Mac, and that the downloaded file names are correct when using FireFox. However, the download of files from other apps or websites works as expected – even in Safari. Do you have any news on this?
Cheers, Thomas
Describe the bug
When I export a page my installation, the downloaded file is named "html.dms", "plaintext.dms" and "pdf.dms" depending on the export file type. When I rename the downloaded file using the correct suffix, it opens up and is properly displayed.
Steps To Reproduce
Steps to reproduce the behavior:
Expected behavior
The downloaded file should be named "page title.file type" e.g. "foo.pdf"
Your Configuration (please complete the following information):
Additional context
At the moment users can easily work around as described above.
@ajvolin commented on GitHub (Sep 22, 2018):
@tomasjay I ran into this same issue recently.
The content disposition headers are missing a closing double quote after the file extension and Safari bugs out. The issue is easily resolved by modifying the content disposition headers for each export method in the following controllers:
v0.22-dev
app/Http/Controllers/BookController.php
Change line 304 from
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.pdf'
To
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.pdf"'
Change line 319 from
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.html'
To
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.html"'
Change line 334 from
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.txt'
To
'Content-Disposition' => 'attachment; filename="' . $bookSlug . '.txt"'
app/Http/Controllers/ChapterController.php
Change line 255 from
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.pdf'
To
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.pdf"'
Change line 271 from
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.html'
To
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.html"'
Change line 287 from
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.txt'
To
'Content-Disposition' => 'attachment; filename="' . $chapterSlug . '.txt"'
app/Http/Controllers/PageController.php
Change line 505 from
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.pdf'
To
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.pdf"'
Change line 522 from
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.html'
To
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.html"'
Change line 538 from
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.txt'
To
'Content-Disposition' => 'attachment; filename="' . $pageSlug . '.txt"'
@ssddanbrown commented on GitHub (Sep 22, 2018):
Great find @ajvolin. Thank you very much.
Just deployed a fix in
5c2e3f4e56. Will be in the next release.@tomasjay commented on GitHub (Oct 12, 2018):
Hi @ssddanbrown , I can confirm that with v0.24.1 the behaviour on Safari is as expected.
Thanks a lot!
@estoimenova commented on GitHub (Nov 14, 2018):
Hi, I want to ask if any of you have faced the following issue: Safari automatically downloads a dtag.dms file while opening Linkedin? Safari version is 12.0. I am curious what could be the reason?
Thank you very much in advance!
@OutsourcedGuru commented on GitHub (Jul 25, 2019):
Indeed. I just visited LinkedIn today and—for the first time ever—it automatically downloaded a
dtag.dmsfile to my Downloads. The file is zero bytes in length so it's unlikely to be anything destructive at this length.This appears in the source HTML and presumably is the cause.
Visiting the link
https://www.linkedin.com/csp/dtag?p=10redirects tohttps://dc.ads.linkedin.com/collect/?pid=6883&li_id=AgAAGuMDAc8sAYxUF6ddX2P4vU5NmhoyOSeRoM3dKA&li_oo=false&li_update=false&li_active=true&max_age=86400&fmt=gifand delivers a 1x1 GIF calledcollect.gif.So it's possible that Safari sees this behavior as questionable tracking and is trying to deny it.
I just added an entry to my MacBook's
/private/etc/hostsfile:In theory, this will prevent LinkedIn's ad server from being reached. And this then should make that weird
dtag.dmsdownload go away.