mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
419 Page Expired When Trying to Save Labels for Pages #4874
Closed
opened 2026-02-05 09:22:47 +03:00 by OVERLORD
·
19 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label
🐛 Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#4874
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mschoon85 on GitHub (Jul 15, 2024).
Describe the Bug
Hi @ssddanbrown
We are experiencing intermittent issues when saving a page after adding labels. The problem occurs frequently but not consistently. If it were a settings issue, it would either always work or never work. This might be worth investigating, as it can be quite annoying for our users.
Kind regards,
Michel
Steps to Reproduce
Expected Behaviour
No error
Screenshots or Additional Context
Browser Details
MS Edge
Exact BookStack Version
24.05.1
@ssddanbrown commented on GitHub (Jul 15, 2024):
Hi @mschoon85,
This will typically be something specific to your environment/scenario, and can often be due to another requested being made, and failing, in the background for some reason.
Are you familiar with the browser development tools? If so, it would be useful if you could open the console tab, then refresh then page (when in the editor), then report back the messages shown (if any).
@mschoon85 commented on GitHub (Jul 15, 2024):
Hi @ssddanbrown,
When I open the page and there is nothing in the console, adding the labels and then saving the page works without any issues. However, when I see this message in the console after clicking on edit, the saving of labels fails:
Before saving:
After saving:
Click here url: https://learn.microsoft.com/nl-nl/microsoft-edge/devtools-guide-chromium/console/copilot-explain-console#the-explain-this-error-feature
@mschoon85 commented on GitHub (Jul 15, 2024):
I have more information on the second attempt. During the first attempt, we did not wait long enough for the other errors to appear. They show up as soon as I add a label on the second attempt.
@mschoon85 commented on GitHub (Jul 15, 2024):
@mschoon85 commented on GitHub (Jul 15, 2024):
I also notice that when I get the error message and then press the back button in the browser, SSO logs in again.
@ssddanbrown commented on GitHub (Jul 15, 2024):
Thanks for the info @mschoon85.
Can you watch your BookStack error log file and report back any errors that get added when you go through the process of adding new tags to a page.
@mschoon85 commented on GitHub (Jul 16, 2024):
@ssddanbrown, Please find attached the logfile from the period when I was attempting to reproduce the issue. There were many errors in the console, but I was also able to save the page several times without any console errors. Eventually, I was able to reproduce the 419 Page Expired error, which should be at the end of the logfile.
laravel - Copy.log
@mschoon85 commented on GitHub (Jul 16, 2024):
These are the two errors I have found. I do not have a user named 'forge' in the database. This user is also unknown to me. Could it be something that BookStack uses? The database user for BookStack is named 'Bookstack'.
@mschoon85 commented on GitHub (Jul 16, 2024):
I found at least one reference to a 'forge' user:
D:\Apache24\htdocs\bookstack\app\Config\database.php (2 hits)
Line 65: 'database' => env('DB_DATABASE', 'forge'),
Line 66: 'username' => env('DB_USERNAME', 'forge'),
It seems that is is set correctly:
@mschoon85 commented on GitHub (Jul 16, 2024):
I was advised to clear the caches, but I encountered the following error:
@ssddanbrown commented on GitHub (Jul 16, 2024):
Ah, a windows based apache environment.
Yeah, that can be prone to thread safety issues which is likely what's occurring here since we can see the config reflecting defaults.
Config caching can be a workaround but that will conflict with custom theme functions (we don't officially advise/document config caching) unless that's specifically handled in the theme code by wrapping functions in exist checks, eg:
We could maybe look to make the theme work with cache (load functions.php only once) and/or update config usage to avoid non-thread-safe functions but some further testing required there to properly check potential impacts.
Dev references
bba7dcce49/app/Theming/ThemeService.php (L77)@mschoon85 commented on GitHub (Jul 16, 2024):
@ssddanbrown I don't believe the theme is causing the 419 error. This issue was occurring even before we implemented the autosort 'hack'. After every Bookstack update, we clear those three caches. Last Friday, we implemented the autosort 'hack' after payment. It would be great to make this compatible with clearing the 'php artisan config' command as well.
How should we proceed with investigating the 419 issue? Did you see all my previous messages with the logs, etc.?
@ssddanbrown commented on GitHub (Jul 16, 2024):
@mschoon85 I'm not saying the theme is causing it, but that caching can help in thread-safety-prone environments like yours, which you can't run since the combined use and implementation of the theme system is not compatible.
If you wrap your theme functions like shown above, you should be able to cache the config to avoid config thread-safety issues. You'll need to remember to re-cache (or clear) this config cache upon any future updates, or when making any
.envchanges in the future.@mschoon85 commented on GitHub (Jul 16, 2024):
@ssddanbrown
Wrapping the function as shown below will result in an error:
@mschoon85 commented on GitHub (Jul 16, 2024):
I did it this way, and now it works:
@mschoon85 commented on GitHub (Jul 16, 2024):
Perhaps the functions.php file on https://www.bookstackapp.com/hacks/autosort-tagged-books needs the above addition as well.
@mschoon85 commented on GitHub (Jul 17, 2024):
@ssddanbrown , It appears that the issue has been resolved by wrapping the function and clearing those three caches. I am currently unable to reproduce the problem.
@mschoon85 commented on GitHub (Jul 17, 2024):
I also noticed that the php artisan config:cache command was missing from my update script. It would be beneficial to add this command to the list on the BookStack update documentation (https://www.bookstackapp.com/docs/admin/updates/).
For your reference, or for anyone else who might be interested, here is my (powershell) update script, which includes file and database backup:
Details
@ssddanbrown commented on GitHub (Jul 17, 2024):
@mschoon85 I don't advise config caching in our guidance to avoid the impacts in support it can introduce. All this is rarely an issue in realistic production environments, it's only really relevant in edge cases (like Apache on windows, which I'd consider more of a dev environment to be honest).
I've opened up #5126 to look into removing the thread unsafe functions, to avoid this at a more fundamental layer.
And I've opened #5125 for improving how the theme system works with commands like config:cache (even if undocumented).
I'll therefore close this off.