mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 09:09:38 +03:00
Editor draft actions should dismiss existing notifications so success notifications are clear #4796
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @WyattBest on GitHub (May 23, 2024).
Dan Edit: This issue was re-purposed to focus on making the notifications clearer, as discussed further on in this issue. The original bug report details below may not be so relevant, but remain for context.
Describe the Bug
Editing a draft that is older than the current version of the page produces this warning:
It seems that this should say "recommended that you delete this draft." Or perhaps something is wrong with the discard draft action.
Steps to Reproduce
Expected Behaviour
I would expect that clicking Discard Draft would resolve the warning about needing to discard the draft.
Screenshots or Additional Context
Browser Details
Firefox 126.0 on Windows 10
Exact BookStack Version
v24.05.1
@ssddanbrown commented on GitHub (May 23, 2024):
Hi @WyattBest,
This indicates there may be another issue in your environment. The page should not reload when you click to discard or delete a draft. Do you mean this as a browser page reload, or by "reload" are you referencing the bookstack editor just loading in new content?
Although this could be delete, I would prefer to keep this discard as a safer option since the old draft content will exist until a new draft is saved (or auto-saved) which provides a little safety in the event that this was a mistake. This does mean that the old content and warning may re-appear if the user re-edits without having saved a draft since, but that should be infrequent and a reasonable tradeoff IMO.
@WyattBest commented on GitHub (May 23, 2024):
@ssddanbrown Thank you for responding! You're right; the page does not actually reload. Everything works as you described.
My last remaining confusion stems from the z-index of the notification bubbles. Discarding the draft gives a green success message that it's OK to edit, but it's hidden behind the orange warning. Perhaps notifications should have the newest on top?
@ssddanbrown commented on GitHub (May 24, 2024):
@WyattBest Yeah, we should probably dismiss existing warnings when that action is taken to avoid the overlap.
I'll go ahead and re-purpose this issue to focus on that as an improvement.
@patlecat commented on GitHub (Jun 2, 2025):
There's no draft management, therefore it's very scary when this message pops up. I'm afraid to discard or delete the draft, even after several saves! I have no clue what state the page is in. This should really be clarified in any message but may also need an additional action in the menu like: