Disabling Comments #456

Closed
opened 2026-02-04 20:09:38 +03:00 by OVERLORD · 14 comments
Owner

Originally created by @Ethanb00 on GitHub (Oct 3, 2017).

Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book.

For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it.

As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page. Turning it off would remove an unused a page component and clean up the UI a bit.

Thank you!

Originally created by @Ethanb00 on GitHub (Oct 3, 2017). Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book. For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it. As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page. Turning it off would remove an unused a page component and clean up the UI a bit. Thank you!
OVERLORD added the 🛠️ Enhancement label 2026-02-04 20:09:38 +03:00
Author
Owner

@Shackelford-Arden commented on GitHub (Oct 3, 2017):

I like this idea. Definitely like the idea of having book/chapter level control of comments.

I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a Chapter/Book Settings menu?

@Shackelford-Arden commented on GitHub (Oct 3, 2017): I like this idea. Definitely like the idea of having book/chapter level control of comments. I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a **Chapter/Book Settings** menu?
Author
Owner

@slimninja commented on GitHub (Oct 4, 2017):

+1

@slimninja commented on GitHub (Oct 4, 2017): +1
Author
Owner

@criskolkman commented on GitHub (Oct 10, 2017):

+1 for me!

@criskolkman commented on GitHub (Oct 10, 2017): +1 for me!
Author
Owner

@faizmali commented on GitHub (Oct 20, 2017):

We would greatly appreciate this feautre as well

@faizmali commented on GitHub (Oct 20, 2017): We would greatly appreciate this feautre as well
Author
Owner

@galaxyfeeder commented on GitHub (Oct 28, 2017):

+1

@galaxyfeeder commented on GitHub (Oct 28, 2017): +1
Author
Owner

@Abijeet commented on GitHub (Oct 28, 2017):

Ok, there a few ways this can be done,

Option Role
Global option Only administrator can do this.
Option on the book People who have modify access to the book
Option on the chapter People who have modify access to the chapter
Option on the page People who have modify access to the page

I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.

@Abijeet commented on GitHub (Oct 28, 2017): Ok, there a few ways this can be done, | Option | Role | |-----------------------|----------------------------------------------| | Global option | Only administrator can do this. | | Option on the book | People who have modify access to the book | | Option on the chapter | People who have modify access to the chapter | | Option on the page | People who have modify access to the page | I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.
Author
Owner

@Ethanb00 commented on GitHub (Oct 30, 2017):

@abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation.

Thank you for your work!

@Ethanb00 commented on GitHub (Oct 30, 2017): @abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation. Thank you for your work!
Author
Owner

@ssddanbrown commented on GitHub (Nov 11, 2017):

Yeah, I think we should keep this at a global (admin) level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like.

@ssddanbrown commented on GitHub (Nov 11, 2017): Yeah, I think we should keep this at a global (admin) level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like.
Author
Owner

@Abijeet commented on GitHub (Nov 15, 2017):

Have started working on this, few things to note -

  1. Added an option under app settings - Disable comments
  2. If this is turned on then,
    1. Adding comments is disabled.
    2. Existing comments will not be shown.
    3. The entire comments section is removed and no message is shown stating that comments are disabled.

Two things are debatable here,

  1. Do we show a message stating that comments are disabled? Not sure if it's needed, but can be easily added.
  2. Do we show existing comments? I removed them to save an extra query to fetch the comments.
@Abijeet commented on GitHub (Nov 15, 2017): Have started working on this, few things to note - 1. Added an option under app settings - **Disable comments** 2. If this is turned **on** then, 1. Adding comments is disabled. 2. Existing comments will not be shown. 3. The entire comments section is removed and no message is shown stating that comments are disabled. Two things are debatable here, 1. _Do we show a message stating that comments are disabled?_ Not sure if it's needed, but can be easily added. 2. _Do we show existing comments?_ I removed them to save an extra query to fetch the comments.
Author
Owner

@Shackelford-Arden commented on GitHub (Nov 15, 2017):

For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query.

@Shackelford-Arden commented on GitHub (Nov 15, 2017): For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query.
Author
Owner

@Ethanb00 commented on GitHub (Nov 16, 2017):

I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page.

@Ethanb00 commented on GitHub (Nov 16, 2017): I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page.
Author
Owner

@jleroy commented on GitHub (Nov 16, 2017):

IMHO @Abijeet choices are good ones. :)

@jleroy commented on GitHub (Nov 16, 2017): IMHO @Abijeet choices are good ones. :)
Author
Owner

@ssddanbrown commented on GitHub (Nov 19, 2017):

I totally agree, Just hide all existence of comments with the option enabled.

@ssddanbrown commented on GitHub (Nov 19, 2017): I totally agree, Just hide all existence of comments with the option enabled.
Author
Owner

@ssddanbrown commented on GitHub (Dec 7, 2017):

Featured now added by @Abijeet within #593. Will be in the next release.

@ssddanbrown commented on GitHub (Dec 7, 2017): Featured now added by @Abijeet within #593. Will be in the next release.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#456