mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-19 19:06:56 +03:00
Change JavaScript form submit() calls to requestSubmit()
#4508
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Mar 13, 2024).
As described here: https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit
This would play nicer with normal event handling.
Thought about while helping build a JS hack, where existing submit event was difficult to override since it ignores the event system.
@shresthkapoor7 commented on GitHub (Jun 20, 2025):
Hey Dan, I’d like to work on this. I’ll audit the .submit() usage across the frontend and swap them with requestSubmit() where safe. Let me know if there are any edge cases I should watch for.
@ssddanbrown commented on GitHub (Jun 23, 2025):
@shresthkapoor7 Sure, go ahead, thanks!
I'm not sure of any specific edge-cases, I just ask that you manually test each related submit which is changed.