mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 03:12:20 +03:00
WYSIWYG Text direction & Alignment controls can fail when set in nested structures #4463
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Feb 14, 2024).
Specifically in tables where there may be subformatting.
Especially when copied in from other apps like word which may bring more complex content structures.
Probably best if, on text direction or alignment control usage, we traverse to closest block element to apply it, then remove all alignment/direction (attribute and styles) of all child elements, to keep these block-level.
Additionally, text direction controls don't currently apply during multi-table cell selections, only the first.
@ssddanbrown commented on GitHub (Feb 20, 2024):
Addressed in
c290d01adb.Probably not perfect, but now combined with the better clear formatting controls, this should provide the user much more control, or ways to clean & gain control.