mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
BookChild global scope is messing with column selection of page/chapter queries #4448
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ssddanbrown on GitHub (Feb 1, 2024).
Originally assigned to: @ssddanbrown on GitHub.
Specifically:
16af833124/app/Entities/Models/BookChild.php (L25-L32)The
addSelect, where no current selection exists, auto selects all columns.This is leading to way too much data being loaded in where we're trying to be selective, like almost any loading of pages/chapters for lists.
Need to ideally make this select work with others, or otherwise find another route for this.
Will require attention to be payed to what fields are being returned in API responses, as this could now potentially be a backward compatibility break. Relevant to all endpoints showing chapters/pages, maybe including those on parent items (books->show).
@ssddanbrown commented on GitHub (Feb 13, 2024):
Addressed within #4827