mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 03:12:20 +03:00
When replacing an image the new image is not shown until you do a page reload #4399
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jasell on GitHub (Jan 11, 2024).
Describe the Bug
When replacing an image the new image is not shown until you do a page reload
Steps to Reproduce
Expected Behaviour
As the new image is loaded it should update both in the image archive and throughtout in my page
Screenshots or Additional Context
No response
Browser Details
Win 11, Chrome
Exact BookStack Version
Demo page
@ssddanbrown commented on GitHub (Jan 11, 2024):
Hi @jasell,
Yeah, this is is known side affect of performing an in-place change of image, where caching is active.
We could add cache-invalidating query additions to these, but that's getting pretty hacky, especially for images used in-content already, outside of the image manager itself.
Otherwise, there could be other options with certain image storage options we provide, but not sure I'd want to add that complexity for a minor element.
Could be something best pracitally solved to added wording to advise of this scearnio, warning the user old images may be shown for a little while.
@jasell commented on GitHub (Jan 11, 2024):
A simple solution could be to notify the user to do a page reload or F5 to see the effect of the update image.
The Message could be visible until the page is reloaded.