mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 00:59:39 +03:00
Follow Page Bug When Page is Moved to Non-Followed Book #4364
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mschoon85 on GitHub (Dec 13, 2023).
Describe the Bug
Hi @ssddanbrown ,
I might have found a bug. Through the API, I imported a DOCX document into Book A, which I am following, and I receive emails whenever there are changes within the book. Later, I moved the page to another book, let's call it Book B, which I am not following. Surprisingly, I received an email notification when someone made a change to that page, even though it's now in a book I'm not following. In the screenshot below, you can see the details on the page itself. It appears that I am not following it (apologies for the Dutch language), as the "follow" button (volg) is available, and the top details do not indicate that I am following the page.
Kind regards,
Michel
Steps to Reproduce
Enable Notifications for Target Book: Ensure you are following the book where you intend to upload the document. Verify that email notifications are properly configured (e.g., SMTP settings).
Upload Document via API: Upload a DOCX document to this book through the API. Note: The issue might also arise when creating a new page manually, but this has not been tested yet.
Select a Non-Followed Book: Identify a book that you are not currently following and transfer the page to this book.
Test Notification Trigger: Modify the page within the book you're not following. Observe if you receive an email notification regarding this change, which will indicate whether the issue persists.
Expected Behaviour
I would anticipate not receiving an email notification, as the page has been moved to a book that I am not following. Furthermore, the page's details themselves indicate that I am not following it, reinforcing this expectation.
Screenshots or Additional Context
No response
Browser Details
MS Edge
Exact BookStack Version
23.10.4
@ssddanbrown commented on GitHub (Dec 13, 2023):
Hi @mschoon85,
Could you also confirm the notification settings you have in "My account" > "Notification Preferences". Just want to check that these are not the cause.
@mschoon85 commented on GitHub (Dec 13, 2023):
@ssddanbrown
It appears that I am currently following only one book, which is 'Book A' as mentioned in my problem description. 'Book B', on the other hand, is not listed on this page.
@mschoon85 commented on GitHub (Dec 13, 2023):
Ah, I've just noticed that these settings are configured to notify me about pages that I own. This could be the reason behind the issue.
@mschoon85 commented on GitHub (Dec 13, 2023):
I've manually updated the owner through the permissions settings, so I don't expect to receive any more emails regarding this issue.
@ssddanbrown commented on GitHub (Dec 13, 2023):
Yeah, if you're the owner that you're getting notifications due to that general notification preference.
@mschoon85 commented on GitHub (Dec 13, 2023):
Thank you! We can now close the ticket as it's not a bug.