mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 03:12:20 +03:00
Text size varies greatly #4271
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nat-418 on GitHub (Oct 14, 2023).
Describe the Bug
Bookstack has a 39.55 pixel difference between text displayed, for example, here: https://demo.bookstackapp.com/shelves/demo-content .
The largest text is too large and the smallest text is too small. It seriously hampers legibility, and is very aesthetically unpleasing:
For more detail on proper typography for the web, see:https://practicaltypography.com/websites.html
Steps to Reproduce
Expected Behaviour
Text should be sized between 15-25 pixels. Headers should be slightly larger than the body text. For example, if we decide that the body text should be 15 pixels, a header could be 16 pixels. The smallest and largest sizes of text on a page should not be drastically different.
Screenshots or Additional Context
No response
Browser Details
No response
Exact BookStack Version
whatever the demo is running
@otherjoel commented on GitHub (Oct 14, 2023):
All of this is easy to adjust with custom CSS in the settings. Most BookStack admins are going to change the typography to suit their needs anyway.
While I also would tweak some things about BookStack’s typographic defaults, I don’t agree with a fellow typography nerd swooping in here and labeling this as a bug. I also know Matthew Butterick, and I don’t think he would be enthused about his work being used in service of drive-by nitpicking (see, e.g., 1, 2). If you want to evangelize about good typography, do so through your own good typographic works 😉
@ssddanbrown commented on GitHub (Oct 14, 2023):
Thanks for the input @nat-418,
In my view, consistency of font sizes for sure could be improved.
In regards to range of font sizes, I don't doubt a tighter range could visually improve things, but I'm not sure I'd want to tighten things too much in the platform defaults.
The example you're showing has a particularly large range due to the shelf heading.
This heading is aligned with the sizes of that for books, chapters and pages so the names of these core items appear consistent as your travel down.
Since the is a platform of user-content, and users have access to a range of headers, by default the main heading is quite large since we accommodate several options levels beneath this.
I like to ensure these are distinct without much additional opinionated design/style thrown in, and therefore sizing is used.
If you don't like the sizes/styles used, you can always customize/override the styles.
A 1px difference is quite hard to see in my opinion. Of course you could use other methods of distinguishment, but as said above I like to keep the defaults fairly vanilla & free of much additional styling choices.
I'm happy to take on this input, for choices I make going forward, but I don't expect to change things to work to the range you're requesting, and I may close this off as opionated change requests such as this can be hard to manage.
@nat-418 commented on GitHub (Oct 15, 2023):
Thanks for taking the time to respond. I checked out Bookstack because I saw your posts when looking for a good self-hosted wiki. I noticed you called it opinionated software. If you don't want to do such a small range that I suggested, I respect your decision as the project maintainer. I think you could figure out a way to reduce the range between huge and tiny text, but if you don't want to do that, that's your free choice.
@ssddanbrown commented on GitHub (Oct 20, 2023):
Thanks for your understanding. I'm going to close this off since I don't see enforcing a specific rule on the project, or a specific action to target right now, but I'll keep this feedback in mind when working on default design elements going forward.