mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
Add warning when removing default permissions without overrides #4256
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aswgxf on GitHub (Oct 3, 2023).
Describe the feature you'd like
I have noticed that if you edit the permissions on an item and uncheck the Inherit defaults box for Everyone Else then save, the item will become inaccessible to everyone, including the Owner of the item, except for the Admins role.
I would like a warning to popup when you attempt to save the permissions that lets the user know that they didn't set any permission overrides, and this may make the item inaccessible to everyone.
Describe the benefits this would bring to existing BookStack users
In a multi user environment, where not everyone is an admin, this would help prevent users from hiding content they own from themselves accidentally.
Can the goal of this request already be achieved via other means?
An alternative solution would be to allow the owner of an item to always have access to at least edit the permissions of it, if not just full permission override. Other than that I am not aware of any way to prevent users from removing their own permissions.
Have you searched for an existing open/closed issue?
How long have you been using BookStack?
3 months to 1 year
Additional context
No response
@ssddanbrown commented on GitHub (Oct 3, 2023):
Thanks for the suggestion @aswgxf,
I wouldn't want to show a warning based on specific permission options selected (or lack of selection) since no overrides could be commonly desired in some environments, and that wouldn't specifically cover the pain points raised.
Instead I'd prefer to address the pain point directly, which I guess would be showing a warning if the configured permissions will remove view access to the permission setter, or the owner. Will be a bit more complex to implement though.
@aswgxf commented on GitHub (Oct 3, 2023):
Oh that's a good point. Just warning if no overrides are selected also wouldn't help if they do select overrides, but they aren't in the roles they've added.
Originally I was just going with "warn if no overrides" because I wasn't sure if actually evaluating the permissions would be too complex to be worth it. If you think it could be done without too much pain though, that's a much better option.