mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
Videoplayer integration #4246
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @towerplease on GitHub (Sep 28, 2023).
Describe the feature you'd like
As the count of videos added to bookstack in my instance is constantly growing, the current implementation of video playback could be optimized.
As fas as i know, there is no better way to upload videos, as of uploading it as an attachment, then using the direct-link to that attachment and add it via "add media".
For me i found that way "working", but it is now as good as i could be.
For example, i had to play around with the width and height values, to find a nice sweetspot. Currently 840 and 420 looks fine:
This results in a display that uses the browser's default media player (Firefox):
It would be nice, there were like an Mediamanager also for videos, with an integrated videoplayer provided by bookstack. This would also optimize the streaming capabilities for the user and the video does not has to be viewed as an attachment (which also should be an available option)
Its not a must have feature, but a really "nice to have" thing.
I am using confluence at work, and there is also a video player provided, little features like a small "download" button and playback speed is also available :)
Thanks in advance!
Describe the benefits this would bring to existing BookStack users
Benefits would be a much smoother userexperience when providing videos.
Can the goal of this request already be achieved via other means?
Yes, as already described, the default method of the browser can be used when inserting media with the attachment link.
Have you searched for an existing open/closed issue?
How long have you been using BookStack?
1 to 5 years
Additional context
You are great!
@ssddanbrown commented on GitHub (Sep 28, 2023):
Thanks for the suggestion @towerplease.
I'll probably close this off though in favor of #882 and #3274 as I feel they already cover the core demand for proper video handling.
Personally I'd probably not look to implement a custom video editor for BookStack, and prefer to remain using native browser functionality where possible since functionality is usually good enough for most BookStack use-cases. Often those features are available via browser at some level, or keeping things default could allow instances to customize with their own desired libraries.
@towerplease commented on GitHub (Sep 29, 2023):
Hi Dan,
thanks for having a look at the feature request. Surely i understand the decision in keeping browser-related features to keep bookstack slim. As i have a path to implement videos thats fine for me.