mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
v23.06.2 Upload images to s3 doesn't work #3952
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yoghiyb on GitHub (Aug 3, 2023).
Describe the Bug
The error is "File path /updates/images/gallery/{image_name} could nto be uploaded to.
like https://github.com/BookStackApp/BookStack/issues/2739
Steps to Reproduce
my poilicy
Expected Behaviour
it shouldn't error
Screenshots or Additional Context
Browser Details
No response
Exact BookStack Version
v23.06.2
PHP Version
8.2
Hosting Environment
Docker
@ssddanbrown commented on GitHub (Aug 3, 2023):
Hi @yoghiyb,
Can you get details of the error event from your BookStack error log?:
https://www.bookstackapp.com/docs/admin/debugging/
@yoghiyb commented on GitHub (Aug 3, 2023):
sure, @ssddanbrown
@ssddanbrown commented on GitHub (Aug 3, 2023):
@yoghiyb Thanks, unfortuantely that cuts off some important lines.
Can you show the lines from the start of an error (where the date is shown) followed by
production.ERROR, along with the next few lines after it (Up to about#10).@yoghiyb commented on GitHub (Aug 3, 2023):
@ssddanbrown sorry for the previous mistake,
this is the full log that i regenerated with a different file
Details
@yoghiyb commented on GitHub (Aug 4, 2023):
@ssddanbrown any update for this?
@ssddanbrown commented on GitHub (Aug 4, 2023):
@yoghiyb No. I'd need to test and attempt to replicate on S3. Not sure when I'll get round to that.
@oxismailxo commented on GitHub (Sep 2, 2023):
Guys, i have the same issue
@yoghiyb please did you find any solution?
Thanks.
@ssddanbrown commented on GitHub (Sep 3, 2023):
I've just tested AWS S3 usage on my dev instance (BookStack ~v23.08). All appears to work as expected.
I get that there are a lot of options and variation within S3 that could cause different behaviour though.
I'd imagine the "Block public access" setting has to be off since we set public ACLs on images upon upload, so that's maybe something to check.
@oxismailxo commented on GitHub (Sep 3, 2023):
@ssddanbrown thank you for your intervention & time, here is my S3 config:
Block public access=OFF
1- Permissions -> Bucket policy:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Principal": "",
"Action": "s3:GetObject",
"Resource": "arn:aws:s3:::bookstack-wiki-test/uploads/"
}
]
}
/////////////////////////////////////////////////////////////////////////////////
2- IAM user Permissions policies:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": "s3:ListBucket",
"Resource": [
"arn:aws:s3:::bookstack-wiki-test/",
"arn:aws:s3:::bookstack-wiki-test"
]
},
{
"Effect": "Allow",
"Action": [
"s3:PutObject",
"s3:PutObjectAcl",
"s3:GetObject",
"s3:GetObjectAcl",
"s3:DeleteObject"
],
"Resource": "arn:aws:s3:::bookstack-wiki-test/"
}
]
}
NOTE-1: images are uploaded successfully to S3 but the error shows up:
NOTE-2: When I upload attachments the error doesn't show up!
I hope this information helps.
Thank you again @ssddanbrown !
@deanoj commented on GitHub (Sep 11, 2023):
The upload is failing here: https://github.com/BookStackApp/BookStack/blob/development/app/Uploads/ImageService.php#L220
If you comment out that line - upload works as expected.
@robertjustjones commented on GitHub (Sep 12, 2023):
Try this hack to avoid that line.
@oxismailxo commented on GitHub (Sep 14, 2023):
@robertjustjones adding STORAGE_S3_ENDPOINT=https://s3.amazonaws.com not worked for me !
the error when uploading images:
@Joespink commented on GitHub (Sep 14, 2023):
@oxismailxo
Need to add the region aswell - "https://s3.eu-west-2.amazonaws.com" works for me
@ssddanbrown commented on GitHub (Sep 14, 2023):
Yeah,
STORAGE_S3_ENDPOINTwill be region dependent, if setting manually for AWS.From my view, this should work though. Happy to hear from anyone more experienced with AWS what might be required here, and why this appears to work for me but not others (Specifically this is the action of setting ACLs to make images public), especially as from the above it has been shown to be failing for those with
PutObjectAclpermissions.@oxismailxo commented on GitHub (Sep 14, 2023):
Thank you so much @Joespink ! finally worked for me after adding STORAGE_S3_ENDPOINT=https://s3.eu-west-1.amazonaws.com/,
thank you, everyone!
@nathanclayton commented on GitHub (Sep 19, 2023):
That makes sense, since AWS defaults all S3 buckets to private by default now, and if you have a policy in place to disable public sharing (instead sharing the data through a cloudfront endpoint), it could cause it to error out.
@nurradityam commented on GitHub (Jan 11, 2024):
i can confirm digital ocean spaces (s3 compatible) is also set permission to private as default, any easy workaround for this?
somehow i can connect by using this url structure:
STORAGE_S3_ENDPOINT=https://(region).digitaloceanspaces.com
STORAGE_URL=https://(bucket).(region).digitaloceanspaces.com
@jasonpincin commented on GitHub (Aug 22, 2024):
Ever figure out how to work around this on digital ocean?
@ssddanbrown commented on GitHub (Aug 23, 2024):
@nurradityam @jasonpincin Worth having a read of my comment here for DigitalOcean: https://github.com/BookStackApp/BookStack/issues/4556#issuecomment-1723231342
@ssddanbrown commented on GitHub (Sep 13, 2025):
I'm going to go ahead and close this off since there's been no further recent discussion, and since I'm pretty sure I altered the permission application (which is the problematic element in many of the above comments) to soft-fail instead of hard-fail.