mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-10 03:12:20 +03:00
unable to save draft #3912
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TomBachelot on GitHub (Jul 12, 2023).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
When creating a new page in bookstack the draft won't save, the creation of the page itself is saved, it appears on the home page as a new page on the draft part but all the content inserted in the draft is never saved.
The green button is not working :
There is a JS error :
Exact BookStack Version
v23.06.1
Log Content
app.js?version=v23.06.1:43 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getContent')
at ar.getContent (app.js?version=v23.06.1:43:2354)
at On.saveDraft (app.js?version=v23.06.1:25:8246)
at On.runAutoSave (app.js?version=v23.06.1:25:8096)
getContent @ app.js?version=v23.06.1:43
saveDraft @ app.js?version=v23.06.1:25
runAutoSave @ app.js?version=v23.06.1:25
PHP Version
PHP Version 8.2.4
Hosting Environment
windows 10 on xampp
@ssddanbrown commented on GitHub (Jul 12, 2023):
Hi @TomBachelot,
Based upon the screenshot, it looks like this is caused by a more significant issue of the WYSIWYG editor not loading properly.
@TomBachelot commented on GitHub (Jul 12, 2023):
Hi @ssddanbrown thank you for your quick respond
Yes, I can write in the editor without any problem, it works perfectly.
but if i reload the page without save it the draft won't save what i wrote
here is the screenshot of the devtool
@ssddanbrown commented on GitHub (Jul 12, 2023):
Thanks for confirming, I still feel the problem lays elsewhere though, the edit area should not be grey, so I feel the editor is not fully loading as required.
git statusfrom your BookStack installation directory?@TomBachelot commented on GitHub (Jul 12, 2023):
The editing area has always been grey when editing for me since the beginning, so I don't see what the problem is ?
Yes I do have active customizations via the "Custom HTML Head Content" :
Custom HTML Head Content.txt
here is the output of the git status command
@ssddanbrown commented on GitHub (Jul 12, 2023):
It's the first script tag in your custom head customizations that's causing problems.
You should not be calling
tinymce.init.Keep in mind that all such customizations are not supported. Always try temporarily removing these first upon coming across issues, especially if making quite extension customizations like you are here.
Also, the amount of changed files isn't great and could interfere with updates. Might just be file permissions though.
Worth running
git config core.fileMode falseand see ifgit statusprovides a cleaner result.@TomBachelot commented on GitHub (Jul 13, 2023):
Thank you, amazing it's working perfectly ! In deed the edit area is now white :)
Alright I'll keep in mind your advices. Thank you.
I did run the command but i still got the same output than before.
Execpt the first two script in my "Custom HTML Head Content" the others are comming from your hack documentation.
@ssddanbrown commented on GitHub (Jul 13, 2023):
Good to hear that worked!
Just keep in mind that the hacks are not supported either, they can cause issues with later BookStack versions.
That's a little worrying.
Things appear to be in a bit of a messy state.
I could help get things back into a clean state, but would need to know:
.envfile andthemes/folder?git pull origin releaseupgrade step.git diff .env.example@TomBachelot commented on GitHub (Jul 13, 2023):
yes i did, here is the list of all the files :
@ssddanbrown commented on GitHub (Jul 18, 2023):
Okay, I'll close this off since the original issue is now solved.
In regard to other files, the app files are not intended to be edited so editing with custom changes will likely cause conflicts and issues when it comes to updating, like it appears to have done here.
You can often reset the state of things by running
git reset --hardbut first consider: