mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 19:06:06 +03:00
Table row whitespace growing, becoming unnecessarily large #3878
Closed
opened 2026-02-05 07:44:59 +03:00 by OVERLORD
·
7 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#3878
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FMCUSystemAdmins on GitHub (Jun 22, 2023).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
We've been having an issue with whitespace growing as we add new rows and adjust existing rows/content within the table. The result ends up being that the rows have an unnecessary amount of whitespace. See attached for example (it is zoomed out to capture extent of whitespace growth).
We've tried editing the source of the table to put HTML tags for auto-sizing and such, but it doesn't have any effect. Manually adjusting each row to collapse the whitespace doesn't work, because the second we do that for subsequent rows, the previous ones start growing.
Any suggestions?
Exact BookStack Version
23.05
Log Content
No response
PHP Version
No response
Hosting Environment
CentOS 7
@ssddanbrown commented on GitHub (Jun 22, 2023):
@FMCUSystemAdmins Please can you confirm the browser in which this occurs in, and the operating system for which that browser is running upon.
Also, please can you confirm if this is reproducible on our demo site:
https://demo.bookstackapp.com/books/bookstack-demo-site/page/logging-in-to-the-demo-site
@FMCUSystemAdmins commented on GitHub (Jun 23, 2023):
@ssddanbrown This is happening in Firefox v102.11.0esr on Windows 10 v22H2. It doesn't happen in either Chrome or Edge. I can't reproduce it on the demo site.
@ssddanbrown commented on GitHub (Jun 24, 2023):
Thanks @FMCUSystemAdmins.
Ah, okay, might make it hard to test and fix if we can't reproduce in other environments.
Can you confirm exactly when and how the growth occurs?:
Also, is this reproducible via inserting a new table? If so, what are the exact steps there?
@FMCUSystemAdmins commented on GitHub (Jun 27, 2023):
@ssddanbrown:
Is this reproducible via inserting a new table? If so, what are the exact steps there? Running through this has shown that it seems to be related to having an ordered list within the table. Here are the steps I did:
1. Create new table with multiple rows
2. Add content to include an ordered list
3. Attempt readjusting row height of row containing the ordered list by double clicking to auto-size. This is the easiest method to see the behavior.
This behavior seems to only be present when using Firefox.
@ssddanbrown commented on GitHub (Jun 29, 2023):
Thanks for providing the detailed information @FMCUSystemAdmins.
That really helped me reproduce what I believe is the same issue.
I traced this down to this bug (or at least non-now-standard behaviour) in Firefox, which would mess with how cell heights would be set and recalculated on any height affecting change.
I've applied a patch in
5ea2d0c57b, which will be part of the next feature release which I'm aiming to release by the end of the month.Alternatively, adding this to the "Custom HTML Head Content" customization setting will effectively allow patching the change on existing BookStack versions if needed:
If the workaround, or changes in the next release, do not address this let me know and I can re-open this.
@FMCUSystemAdmins commented on GitHub (Jun 30, 2023):
@ssddanbrown, happy to help! The custom code works like a charm, thank you!
We'll ensure all is well after applying patch.
@FMCUSystemAdmins commented on GitHub (Jul 11, 2023):
@ssddanbrown, just following up since we updated to v23.06.1 and removed the custom HTML header. The behavior has not returned, so seems like the patch is solid. Thanks again!