mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 16:49:47 +03:00
Setting Timezone breaks audit log #3864
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @WebWalker3D on GitHub (Jun 16, 2023).
Describe the Bug
Everything is being recorded in UTC. This is because the file app.php on line 74 sets it as such. I also understand to fix this, I simply need to add the line
APP_TIMEZONE=America/New_Yorkin the .env and this should correct the timezone issue. Unfortunately, what ends up happening instead is the audit log stops recording any of the logs. Unsetting this in .env fixes the audit log recording.Steps to Reproduce
Expected Behaviour
Screenshots or Additional Context
php.ini date.timezone is set correctly See also #2509
Browser Details
No response
Exact BookStack Version
v23.02.2
PHP Version
8.2.7
Hosting Environment
Ubuntu 22.04.2 LTS VPS @ Digital Ocean, installed following the install instructions for production
@ssddanbrown commented on GitHub (Jun 17, 2023):
Hi @WebWalker3D,
Just tested this, setting
APP_TIMEZONE=America/New_Yorkworks for me.Are you sure this is the case?
And it's not the case that the logs are being recorded, but are just showing up below some of the older UTC logs (Which are recorded with a latter time)? This can happen when going back in time like you're doing here.
@WebWalker3D commented on GitHub (Jun 17, 2023):
Yes, 100% positive. If I turn the .env variable on, nothing further is logged in audit log for anything, ever. The second I remove this from .env everything works again as expected, just UTC
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Dan Brown @.>
Sent: Friday, June 16, 2023 5:22:58 PM
To: BookStackApp/BookStack @.>
Cc: WebWalker3D @.>; Mention @.>
Subject: Re: [BookStackApp/BookStack] Setting Timezone breaks audit log (Issue #4324)
Hi @WebWalker3Dhttps://github.com/WebWalker3D,
Just tested this, setting APP_TIMEZONE=America/New_York works for me.
Unfortunately, what ends up happening instead is the audit log stops recording any of the logs.
Are you sure this is the case?
And it's not the case that the logs are being recorded, but are just showing up below some of the older UTC logs (Which are recorded with a latter time)? This can happen when going back in time like you're doing here.
—
Reply to this email directly, view it on GitHubhttps://github.com/BookStackApp/BookStack/issues/4324#issuecomment-1595332274, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BATMYSN2MFCE3K4SM6JOL6TXLTFDFANCNFSM6AAAAAAZJQWXTA.
You are receiving this because you were mentioned.Message ID: @.***>
@ssddanbrown commented on GitHub (Jun 17, 2023):
@WebWalker3D With the timezone changed as desired, If you create a completely new book, then create a new page within that book, then update that page, do these actions show in the sidebar when going back up and viewing that new book? Under the "Recent Activity" heading.
@WebWalker3D commented on GitHub (Jun 17, 2023):
Large Screenshot
@WebWalker3D commented on GitHub (Jun 17, 2023):
These times are +4 ahead. It's UTC still
@WebWalker3D commented on GitHub (Jun 17, 2023):
If I make the change in the .env file, nothing logs ever in the audit
@ssddanbrown commented on GitHub (Jun 17, 2023):
@WebWalker3D Please can you respond based upon the specific steps in my last comment?
@WebWalker3D commented on GitHub (Jun 17, 2023):
It's the same as you asked
@ssddanbrown commented on GitHub (Jun 17, 2023):
@WebWalker3D That's not what I asked. I'll reformat the steps into bullet points, and specify what to screenshot:
@WebWalker3D commented on GitHub (Jun 17, 2023):
Alright. I'll update on Sunday when I'm in front of a computer and not mobile. Appreciate your time my friend
@WebWalker3D commented on GitHub (Jun 18, 2023):
I'm stupid, sorry. lol
@ssddanbrown commented on GitHub (Jun 18, 2023):
Was data being recorded as expected, but just below/behind existing audit log entries as per my first response?
@WebWalker3D commented on GitHub (Jun 18, 2023):
It was. I just didn't see it because the system was being used so there was a bunch of logs. Today with it not being used, it was easy to see.