npm run-script build does not minify common.js #386

Closed
opened 2026-02-04 19:19:59 +03:00 by OVERLORD · 3 comments
Owner

Originally created by @spaceraccoon on GitHub (Jul 28, 2017).

  • BookStack Version: Latest release
  • PHP Version: 7.0
  • MySQL Version: 5.7
Expected Behavior
  1. Running npm run-script build should produce a minified common.js in public/js of about 800kb, similar to the one in release/the Github repository
Actual Behavior
  1. This was on a completely clean AWS Ubuntu 16.04 EC2 instance with the installation script.
  2. After installing Bookstacks and Node/npm, I ran npm run-script build in the bookstack folder.
  3. The new common.js is huge (7.898MB) and causes a long load time. You can check it out at http://13.59.182.101/js/common.js?version=v0.17.3
  4. My node version is v8.2.1 and npm is 5.3.0
Originally created by @spaceraccoon on GitHub (Jul 28, 2017). * BookStack Version: Latest release * PHP Version: 7.0 * MySQL Version: 5.7 ##### Expected Behavior 1. Running npm run-script build should produce a minified common.js in public/js of about 800kb, similar to the one in release/the Github repository ##### Actual Behavior 1. This was on a completely clean AWS Ubuntu 16.04 EC2 instance with the installation script. 2. After installing Bookstacks and Node/npm, I ran `npm run-script build` in the bookstack folder. 3. The new common.js is huge (7.898MB) and causes a long load time. You can check it out at http://13.59.182.101/js/common.js?version=v0.17.3 4. My node version is v8.2.1 and npm is 5.3.0
Author
Owner

@spaceraccoon commented on GitHub (Jul 28, 2017):

Tested on Node 6.9 as well with the same results.

@spaceraccoon commented on GitHub (Jul 28, 2017): Tested on Node 6.9 as well with the same results.
Author
Owner

@spaceraccoon commented on GitHub (Jul 28, 2017):

Ugh, sorry, should've run run-script production. Please close this. Sorry! I noticed the README says #

Build and minify for production
npm run-script build

Might want to clarify this!

@spaceraccoon commented on GitHub (Jul 28, 2017): Ugh, sorry, should've run run-script production. Please close this. Sorry! I noticed the README says # > Build and minify for production > npm run-script build Might want to clarify this!
Author
Owner

@ssddanbrown commented on GitHub (Jul 28, 2017):

@spaceraccoon Thanks for advising, I've updated the readme to reflect the recent script changes.

I'd generally advise staying away from the master branch unless you're developing though. It often has breaking changes and things that can mess up a production install.

@ssddanbrown commented on GitHub (Jul 28, 2017): @spaceraccoon Thanks for advising, I've updated the readme to reflect the recent script changes. I'd generally advise staying away from the master branch unless you're developing though. It often has breaking changes and things that can mess up a production install.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/BookStack#386