Update ldap_connect usage to avoid deprecated syntax #3827

New Issue

OVERLORD · 2026-02-05T07:35:51+03:00

OVERLORD commented

2026-02-05 07:35:51 +03:00

Originally created by @ssddanbrown on GitHub (May 30, 2023).

Usage of ldap_connect with two params is considered deprecated.
Will likely be official deprecated in code from PHP 8.3.

We use this deprecated syntax by default:
295cd01605/app/Access/Ldap.php (L19)

Note: I think we do essentially use this in the single-param format in many cases, but we always pass a second param to align usage (Which I believe essentially gets ignored).

Assigning to next feature release but we got a fair amount of time before PHP 8.3 so could be moved if needed.

Originally created by @ssddanbrown on GitHub (May 30, 2023). Usage of [ldap_connect](https://www.php.net/ldap_connect) with two params is considered deprecated. Will likely be official deprecated in code from [PHP 8.3](https://wiki.php.net/rfc/deprecations_php_8_3#deprecate_calling_ldap_connect_with_2_parameters). We use this deprecated syntax by default: https://github.com/BookStackApp/BookStack/blob/295cd0160525125bbd7756d7ad07392ae7201cb8/app/Access/Ldap.php#L19 Note: I think we do essentially use this in the single-param format in many cases, but we always pass a second param to align usage (Which I believe essentially gets ignored). Assigning to next feature release but we got a fair amount of time before PHP 8.3 so could be moved if needed.

OVERLORD added the 🔧 Maintenance 🚪 Authentication 🏭 Back-End labels 2026-02-05 07:35:51 +03:00

OVERLORD closed this issue

2026-02-05 07:35:52 +03:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#3827

Update ldap_connect usage to avoid deprecated syntax #3827

Update `ldap_connect` usage to avoid deprecated syntax #3827