mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Wrong pluralization for non-english languages #356
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jonas-koeritz on GitHub (Jun 14, 2017).
For Bug Reports
Expected Behavior
Correct pluralization of terms for non-english languages.
Actual Behavior
The profile view uses str_plural() to pluralize terms. This only works for english nouns. German nouns get pluralized the wrong way.
Proposed fix
Switch to
trans_choice()to provide localized pluralizations.@timoschwarzer commented on GitHub (Aug 16, 2017):
+1
@ssddanbrown commented on GitHub (Sep 10, 2017):
@jonas-koeritz Thanks for creating this issue. View now updated, for v0.18 release, to use trans_choice. Lang files will need to be updated.
Relevant strings can be found under the keys:
entities.x_books,entities.x_chapters,entities.x_pages.