Custom application icon not showing on uploaded images #3496

New Issue

OVERLORD · 2026-02-05T06:54:31+03:00

OVERLORD commented

2026-02-05 06:54:31 +03:00

Originally created by @JK1198 on GitHub (Feb 8, 2023).

Describe the Bug

I set a custom application icon with the new setting. For most sites the icon is used as the favicon. But when I open an image in an new tab it will use the default bookstack favicon.
It seems like that /uploads doesn't use the custom application icon.

Steps to Reproduce

Set custom application icon
Open any site with a image in the text
Click on that image
In the new tab the favicon should be the default bookstack icon

Expected Behaviour

The custom application icon should be used as the favicon.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v23.01.1

PHP Version

8.2

Hosting Environment

Installed on AlmaLinux 9, Apache httpd as webserver

Originally created by @JK1198 on GitHub (Feb 8, 2023). ### Describe the Bug I set a custom application icon with the new setting. For most sites the icon is used as the favicon. But when I open an image in an new tab it will use the default bookstack favicon. It seems like that /uploads doesn't use the custom application icon. ### Steps to Reproduce 1. Set custom application icon 2. Open any site with a image in the text 3. Click on that image 4. In the new tab the favicon should be the default bookstack icon ### Expected Behaviour The custom application icon should be used as the favicon. ### Screenshots or Additional Context _No response_ ### Browser Details _No response_ ### Exact BookStack Version v23.01.1 ### PHP Version 8.2 ### Hosting Environment Installed on AlmaLinux 9, Apache httpd as webserver

OVERLORD added the 🐛 Bug label 2026-02-05 06:54:31 +03:00

OVERLORD closed this issue

2026-02-05 06:54:33 +03:00

OVERLORD commented

2026-02-05 06:54:38 +03:00

@ssddanbrown commented on GitHub (Feb 8, 2023):

Thanks @JK1198 for reporting.
BookStack sets the icon via meta tags, so it will be only used on BookStack-rendered HTML pages.
Images won't go through BookStack at all in most cases.

We'd need to set the public/favicon.ico file directly for that but that's a little bit of a pain since .ico format support is limited and that's not a directory we advise to be writeable, so would need some extra file permission checks around that.

@ssddanbrown commented on GitHub (Feb 8, 2023): Thanks @JK1198 for reporting. BookStack sets the icon via meta tags, so it will be only used on BookStack-rendered HTML pages. Images won't go through BookStack at all in most cases. We'd need to set the `public/favicon.ico` file directly for that but that's a little bit of a pain since `.ico` format support is limited and that's not a directory we advise to be writeable, so would need some extra file permission checks around that.

OVERLORD commented

2026-02-05 06:54:40 +03:00

@ssddanbrown commented on GitHub (Feb 9, 2023):

Have started on this in #4032, having some fun byte-level hacking the fairly-well supported bmp image format into ico format. Seems to work from a quick test.

@ssddanbrown commented on GitHub (Feb 9, 2023): Have started on this in #4032, having some fun byte-level hacking the fairly-well supported `bmp` image format into `ico` format. Seems to work from a quick test.

OVERLORD commented

2026-02-05 06:54:42 +03:00

@ssddanbrown commented on GitHub (Feb 10, 2023):

Now addressed as part of #4032, to be part of the next feature release.

@ssddanbrown commented on GitHub (Feb 10, 2023): Now addressed as part of #4032, to be part of the next feature release.

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/BookStack#3496