mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-05 00:29:48 +03:00
Syntax highlighting no longer exists #343
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @domainzero on GitHub (May 31, 2017).
Expected Behavior
Syntax highlighting should be working.
I pulled from master because I was on auto-pilot, wondering if it broke there.
Actual Behavior
No syntax highlighting is present. Code blocks are displayed correctly but I'm not sure if hljs is actually loading. I have an hljs stylesheet loaded into the head of the page and that isn't changing any of the code blocks either.
@domainzero commented on GitHub (May 31, 2017):
I'm a doofus and should have read the commits.
e5fc6bf5fa- Moved from highlight.js to codemirrorI'll see myself out.
@domainzero commented on GitHub (May 31, 2017):
Ehhh, I guess I might have closed this early. Syntax highlighting still isn't working correctly.
@shatteredsword commented on GitHub (Jun 7, 2017):
To clarify, you are talking about the syntax highlighting in the source code view of TinyMCE editor, correct?
I've noticed this was missing as well.
@domainzero commented on GitHub (Jun 11, 2017):
I should have been more clear. I think the only reason I hit this issue was because I pulled from the master branch instead of the release branch.
I wasn't getting any syntax highlighting on saved pages after the removal of hljs. For now I think this is an expected issue as codemirror wasn't 100% implemented at the time that I updated.
I'ma close this and we can sweat the issue if it persists when codemirror is fully implemented.