mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 09:09:38 +03:00
Possibility to add a gist from github or a gitlab snippet #3419
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reeperbahnause on GitHub (Dec 29, 2022).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
I would like to add a github gist or a gitlab snippet to a page.
I was not able to add a snippet like this:
Exact BookStack Version
21.11.1
Log Content
No response
PHP Version
7.4.26
Hosting Environment
docker compose
@ssddanbrown commented on GitHub (Dec 29, 2022):
Yeah, the system will generally attempt to prevent usage of script tags within content.
You could use some specific syntax, along with some custom JavaScript in the head, to dynamically load custom scripts.
Unfortunately, The GitLab embed script is designed in a way that makes it very difficult to use in such a dynamic way though, so would be fair effort to produce a stable solution via this route.
Alternatively, probably a way about this via hacking around with the PAGE_INCLUDE_PARSE event in our logical theme system but again requires some hackery.
@reeperbahnause commented on GitHub (Dec 30, 2022):
Thank you for your quick response.
Could this issue be converted to a feature request? (if this makes any sense to you?)
Otherwise the issue can be closed, because I think implementing this in a hacky way doesn't make any sense.
@ssddanbrown commented on GitHub (Dec 30, 2022):
To be honest it's not something I'd look to specifically support. We already have code-block support built-in and I don't like to built to specific external platforms. For these kind of things I prefer to instead look at generic ways that can be used to integrate with such platforms, which in this case would be the logical theme system method.
Will therefore close this off.
@reeperbahnause commented on GitHub (Dec 30, 2022):
Sure thing. I understand your opinion on this.
Sorry for the noise ;-)
@ssddanbrown commented on GitHub (Dec 30, 2022):
No worries at all and thanks for the understanding.
If you do decide to do this via customization, don't hesitate to ask for general guidance/pointers.