mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
Broken Api Token back button #3371
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @McHill007 on GitHub (Nov 30, 2022).
Describe the Bug
hi,
it seems like the back button when creating or deleting a token is not working using bookstack with IIS.
The redirect is cutting off the subfolder in the url
href => https://localhost/docs/settings/users/19/#api_tokens (The link still contains docs)
redirect to => https://localhost/settings/users/19/#api_tokens (Redirect does not contain docs anymore)
Steps to Reproduce
or
5.- Delete Token
Expected Behaviour
Return to user settings page
Screenshots or Additional Context
Browser Details
Chrome
Exact BookStack Version
BookStack v22.10.2
PHP Version
8.1
Hosting Environment
Windows Server 2019 with IIS
@ssddanbrown commented on GitHub (Nov 30, 2022):
Have gone through the same flow on our demo instance and my local dev instance, where my local dev instance is hosted on a sub-path. All works as expected.
Really these are just normally generated URLs like any other in the system, the only difference is that have a hash in them.
Makes my think it could be the sub-path handling on the IIS side being thrown off by the hashes.
Couple of questions:
APP_URLenv option for your instance set to exactlyhttps://localhost/docs?@McHill007 commented on GitHub (Nov 30, 2022):
I'm getting an error since I didnt setup mail
Yes, I also rerun the db update script artisan as stated in the env file
@ssddanbrown commented on GitHub (Nov 30, 2022):
Alrighty, thanks, additional questions:
/docsincluded?)@McHill007 commented on GitHub (Nov 30, 2022):
Just testing that, and it seems to look fine. I guess it's related to the created rewrite rules.
@ssddanbrown commented on GitHub (Nov 30, 2022):
Yeah, that would be my guess since BookStack is generating the URLs properly by the sounds of things.
Could maybe be a side affect with BookStack handling hashes on sub-path requests, but would have thought I'd be getting that too in my dev environment if it's an app-level problem.
@McHill007 commented on GitHub (Nov 30, 2022):
Well strange is, if I type the url directly to the browser it works without problem. In this case I would think, it's not a redirect problem.
https://localhost/docs/settings/users/19#api_tokens
Strange behavior.
@ssddanbrown commented on GitHub (Nov 30, 2022):
Very strange. Is it for sure 100% the same URL, including the starting protocol (
https://vshttp://)?Could maybe see this if there was an internal redirect from http to https.
Otherwise, not sure why those two actions would differ.
@McHill007 commented on GitHub (Dec 2, 2022):
No not 100% the same.
https://localhost/docs/settings/users/19#12 <--- ok
https://localhost/docs/settings/users/19/#12 <--- broken
I'm quite sure it's related to the following IIS rewrite rule, but I didn't manage to fix it.
I removed the anchors from the token view and the userapitokencontroller and it works - of course the redirect is not jumping to the token anchor anymore, but that's ok for me.
@ssddanbrown commented on GitHub (Dec 2, 2022):
@McHill007 I have no idea about IIS and its redirect system, but looking at the regex you might have slightly better luck by keeping the end anchor and instead make the slash optional:
^(.*)/?$. Should ensure it matches up to the end while retaining the same behavior you currently have by omitting trailing slashes.@McHill007 commented on GitHub (Dec 2, 2022):
I tried that, but with the rule
^(.*)/?$I get the mentioned problem with every link - it cuts off the docs/. I also tried to remove the hash tags with a sperate rule - no luck.@ssddanbrown commented on GitHub (Feb 6, 2023):
I'm going to go ahead and close this off since, from above, I have not seen it as an issue in BookStack's handling and since I can't dig into this much further without spending a fair amount of time in an attempt to replicate the environment.