mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
There is not option to choose relative links #3283
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jrmiller82 on GitHub (Oct 17, 2022).
Describe the Bug
When inserting a link it is putting in an absolute link i.e.
http://[IP address]/books/[bookname]/[pagename]. This makes a demo/production workflow difficult, makes migrating domains difficult to impossible, and makes markdown code otherwise really messy.Steps to Reproduce
Insert any link even for an internal link and you'll have an absolute path instead of a relative path.
Expected Behaviour
I expect the software to allow either relative links or absolute links, like practically all (all?) other wiki or CMS software.
Screenshots or Additional Context
This is pretty much a deal killer bug / oversight. It's like having a word processor that doesn't have a forward delete option, and then being told you can only use backwards delete.
If this is an intentional design pattern I truly don't understand that position.
Browser Details
No response
Exact BookStack Version
22.09.1
PHP Version
No response
Hosting Environment
docker image from linuxserver.io
@ssddanbrown commented on GitHub (Oct 18, 2022):
Hi @jrmiller82,
Not so much a bug, since it's not a break or issue with existing functionality, but instead functionality that does not align with your expectations or desires.
We have a built-in command to update database references when desired.
I'm going to close this off as a duplicate as I feel the fundamental request is already covered by #1342. My thoughts and some historical context can be found within my comments on that issue, in addition to my comments in PR #1275.
@jrmiller82 commented on GitHub (Oct 18, 2022):
I am not understanding why you want users to be running commands to update urls in the database, when you should be using relative links like every other wiki/cms out there?
@ssddanbrown commented on GitHub (Oct 18, 2022):
This is only required when changing the domain/base-url used, so I only expect it to be used in infrequent scenarios.
In your opinion. Absolute links provide some benefits such as less side affects and generally better stability & portability, along with better identification potential.
Not all. Pretty sure wordpress still sticks to absolute links also.
Either way, relative or absolute, they'd bring their own challenges or limitations. I used absolute early on to prevent some in-editor issues, and have since leant further into using absolute links. I don't see switching or supporting both as worth the effort at this time.