mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-07 03:09:44 +03:00
API update page not working #2963
Closed
opened 2026-02-05 05:52:08 +03:00 by OVERLORD
·
5 comments
No Branch/Tag Specified
development
further_theme_development
l10n_development
release
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#2963
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JtheBAB on GitHub (Aug 15, 2022).
Attempted Debugging
Searched GitHub Issues
Describe the Scenario
I am playing around with the API System and try to update a page.
I send the following body:
{"id":1982,"book_id":37,"chapter_id":0,"name":"test","html":"<p id=\"bkmrk-das-ist-ein-test\">Das ist ein <strong>Test<\/strong> - Update<\/p>"}by using
Invoke-WebRequest -uri https://url/api/pages/1982 -Headers $Headers -method PUT -Body $bodyI get
StatusCode : 200 StatusDescription : OK Content : {"id":1982,"book_id":37,"chapter_id":0,"name":"test","slug":"test","html":"<p id=\"bkmrk-das-ist-ein-test\">Das ist ein <strong>Test<\/strong><\/p>","priority":11,"created_at":"2022-08-15T13:25:53.000...and see on the corresponding bookstack page that the Revision counter goes up and the "Updated ..." changes. But the text stays at the old version and also when i click on the Revision link i just see the real changes and not all my tests.
Any idea why the page isn't updated?
Exact BookStack Version
v22.07.3
Log Content
PHP Version
7.4
Hosting Environment
Debian 11
@ssddanbrown commented on GitHub (Aug 15, 2022):
Hi @JtheBAB,
Content-Typeheader?@JtheBAB commented on GitHub (Aug 15, 2022):
Hi @ssddanbrown
Yes.
Original:
"html":"<p id=\"bkmrk-das-ist-ein-test\">Das ist ein <strong>Test<\/strong><\/p>"New:
"html":"<p id=\"bkmrk-das-ist-ein-test\">Das ist ein <strong>Test<\/strong> - Update<\/p>"Basically the same as in the API documentation. But also when i replace it to
"html":"Bla bla"the page doesn't change.
I guess so as i sent now (above it is missed).
$contentType = "application/x-www-form-urlencoded"Invoke-WebRequest -uri https://url/api/pages/1982 -Headers $Headers -method PUT -Body $body -ContentType $contentType@ssddanbrown commented on GitHub (Aug 16, 2022):
Hi @JtheBAB,
If you are sending JSON content like in your original example above your request content type will need to match, and therefore be
application/json@JtheBAB commented on GitHub (Aug 16, 2022):
Hi @ssddanbrown
Thank you. Then i complete misunderstand the docs in the "Request Format" section. Now it works with:
$contentType = "application/json" Invoke-WebRequest -uri https://url/api/pages/1982 -Headers $Headers -method PUT -Body $body -ContentType $contentTypewith
{"id":1982,"book_id":37,"name":"test","html":"Bla bla"}as payload.
As a side note:
When i do a GET on that page, Bookstack delivers with "chapter":0. But when i send it with "chapter":0 i get
{"error":{"message":"No query results for model [BookStack\\Entities\\Models\\Chapter] 0","code":404}}Thank you again :)
@ssddanbrown commented on GitHub (Aug 23, 2022):
Within
760eff397fI have now updated the "Request Format" section to clarify things to help avoid confusion in future. I will therefore close this off.In regards to the chapter id, yeah, there is some misalignment currently for requests/responses, since BookStack internally uses
0to denote lack of relation but the API expectsnullfrom users.