mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-13 03:13:58 +03:00
Revision datetime not shown when locale uses non-utf8 encoding #2919
Closed
opened 2026-02-05 05:43:33 +03:00 by OVERLORD
·
7 comments
No Branch/Tag Specified
development
l10n_development
release
v25-12
llm_only
vectors
v25-11
docker_env
drawio_rendering
user_permissions
ldap_host_failover
svg_image
prosemirror
captcha_example
fix/video-export
v25.12.3
v25.12.2
v25.12.1
v25.12
v25.11.6
v25.11.5
v25.11.4
v24.11.4
v25.11.3
v25.11.2
v25.11.1
v25.11
v25.07.3
v25.07.2
v25.07.1
v25.07
v25.05.2
v25.05.1
v25.05
v25.02.5
v25.02.4
v25.02.3
v25.02.2
v25.02.1
v25.02
v24.12.1
v24.12
v24.10.3
v24.10.2
v24.10.1
v24.10
v24.05.4
v24.05.3
v24.05.2
v24.05.1
v24.05
v24.02.3
v24.02.2
v24.02.1
v24.02
v23.12.3
v23.12.2
v23.12.1
v23.12
v23.10.4
v23.10.3
v23.10.2
v23.10.1
v23.10
v23.08.3
v23.08.2
v23.08.1
v23.08
v23.06.2
v23.06.1
v23.06
v23.05.2
v23.05.1
v23.05
v23.02.3
v23.02.2
v23.02.1
v23.02
v23.01.1
v23.01
v22.11.1
v22.11
v22.10.2
v22.10.1
v22.10
v22.09.1
v22.09
v22.07.3
v22.07.2
v22.07.1
v22.07
v22.06.2
v22.06.1
v22.06
v22.04.2
v22.04.1
v22.04
v22.03.1
v22.03
v22.02.3
v22.02.2
v22.02.1
v22.02
v21.12.5
v21.12.4
v21.12.3
v21.12.2
v21.12.1
v21.12
v21.11.3
v21.11.2
v21.11.1
v21.11
v21.10.3
v21.10.2
v21.10.1
v21.10
v21.08.6
v21.08.5
v21.08.4
v21.08.3
v21.08.2
v21.08.1
v21.08
v21.05.4
v21.05.3
v21.05.2
v21.05.1
v21.05
v21.04.6
v21.04.5
v21.04.4
v21.04.3
v21.04.2
v21.04.1
v21.04
v0.31.8
v0.31.7
v0.31.6
v0.31.5
v0.31.4
v0.31.3
v0.31.2
v0.31.1
v0.31.0
v0.30.7
v0.30.6
v0.30.5
v0.30.4
v0.30.3
v0.30.2
v0.30.1
v0.30.0
v0.29.3
v0.29.2
v0.29.1
v0.29.0
v0.28.3
v0.28.2
v0.28.1
v0.28.0
v0.27.5
v0.27.4
v0.27.3
v0.27.2
v0.27.1
v0.27
v0.26.4
v0.26.3
v0.26.2
v0.26.1
v0.26.0
v0.25.5
v0.25.4
v0.25.3
v0.25.2
v0.25.1
v0.25.0
v0.24.3
v0.24.2
v0.24.1
v0.24.0
v0.23.2
v0.23.1
v0.23.0
v0.22.0
v0.21.0
v0.20.3
v0.20.2
v0.20.1
v0.20.0
v0.19.0
v0.18.5
v0.18.4
v0.18.3
v0.18.2
v0.18.1
v0.18.0
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.1
v0.13.0
v0.12.2
v0.12.1
v0.12.0
v0.11.2
v0.11.1
v0.11.0
v0.10.0
v0.9.3
v0.9.2
v0.9.1
v0.9.0
v0.8.2
v0.8.1
v0.8.0
v0.7.6
v0.7.5
v0.7.4
v0.7.3
0.7.2
v.0.7.1
v0.7.0
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.0
Labels
Clear labels
🎨 Design
📖 Docs Update
🐛 Bug
🐛 Bug
:cat2:🐈 Possible duplicate
💿 Database
☕ Open to discussion
💻 Front-End
🐕 Support
🚪 Authentication
🌍 Translations
🔌 API Task
🏭 Back-End
⛲ Upstream
🔨 Feature Request
🛠️ Enhancement
🛠️ Enhancement
🛠️ Enhancement
❤️ Happy feedback
🔒 Security
🔍 Pending Validation
💆 UX
📝 WYSIWYG Editor
🌔 Out of scope
🔩 API Request
:octocat: Admin/Meta
🖌️ View Customization
❓ Question
🚀 Priority
🛡️ Blocked
🚚 Export System
♿ A11y
🔧 Maintenance
> Markdown Editor
pull-request
Mirrored from GitHub Pull Request
No Label
🔨 Feature Request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/BookStack#2919
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @10935336 on GitHub (Jul 22, 2022).
Describe the feature you'd like
Provide the creation and modification time at page details(I noticed that the unlocalized precise time can be seen when hovering over the relative time of page details, but revisions cannot. )
Describe the benefits this would bring to existing BookStack users
Sometimes, I need to use the precise time of page modification.
For example, if I want to mark that this article was published on a certain day, the information may be out of date.
But I go to the page and I can only see inaccurate information like 2 years ago. So I had to go into the database to see the exact time.
In addition, we also need precise time when resolving some collaborative conflicts
Can the goal of this request already be achieved via other means?
Deep in the database.
Have you searched for an existing open/closed issue?
How long have you been using BookStack?
1 to 5 years
Additional context
@ssddanbrown commented on GitHub (Jul 25, 2022):
Hi @10935336,
This is how that appears on my instance:
Date localization is handled by PHP and the locales on the host system. You may need to ensure that the relevant language locales are installed on the host system.
@10935336 commented on GitHub (Jul 25, 2022):
The exact time is not displayed on my instance, after looking at your picture,Tried switching to English and other languages, it did work. But no matter if I switch to Simplified Chinese or Traditional Chinese, only relative time is displayed.
I've tried multiple devices and browsers, but all only show relative time. So it's presumably not a client-side issue.
Do have multiple locales on the host system and display mostly in Chinese.
output
Do you have any ideas?
@ssddanbrown commented on GitHub (Jul 25, 2022):
@10935336 How are you running BookStack? What operating system are you using on the host machine?
@10935336 commented on GitHub (Jul 26, 2022):
Update:

After looking at the source code, I noticed that the same
formatLocalized('%e %B %Y %H:%M:%S')is used in the export systemSo I tried to export the page in HTML and I ended up with the following
Edit:
Given that the issue has been resolved, some details have been removed as it may affect system security.
@Statium commented on GitHub (Aug 15, 2022):
I have a similar problem. In Russian.
@ssddanbrown commented on GitHub (Aug 22, 2022):
I done some deeper testing of this today, by creating a fresh RHEL-based install, and I can confirm this behaviour.
It seems to be caused by a non-UTF8 locale being used by BookStack, when the system default encoding for a locale is not utf8.
We can updated the behaviour to prioritise usage of utf8-based locales.
Have assigned to the next feature release and updated the title to align.
Note to self for changes
Need to updated this:
b4f29a85ab/app/Http/Middleware/Localization.php (L136-L139)To attempt utf8 usage first, so swtich these around. Have tested this solution.
Can just provide list of locales to
setlocaleinstead of having the if statement (docs).@ssddanbrown commented on GitHub (Sep 2, 2022):
Behaviour has now been amended in
9158a66bffand will be part of the next feature release.