mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-08 11:19:36 +03:00
Iframe works on desktop but not on mobile #2850
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @thomasmoors on GitHub (Jun 14, 2022).
Describe the Bug
With the risk this is some browser specific bug.
I embedded a google calendar through an iframe. I had to add the google calendar domain to
ALLOWED_IFRAME_SOURCES. Now it works on desktop (Chrome, windows) but not on mobile (Chrome, android). Any idea what this might be? If not I will tak some time in the future to debug the mobile browser through debugging tools, but it's a big hassle to set up.Desktop
Mobile
Steps to Reproduce
ALLOWED_IFRAME_SOURCEShttps://calendar.google.comExpected Behaviour
To show the content of the iframe on the page on mobile
Screenshots or Additional Context
No response
Browser Details
chrome mobile
Exact BookStack Version
BookStack v22.04.2
PHP Version
No response
Hosting Environment
shared
@ssddanbrown commented on GitHub (Jun 14, 2022):
Hi @thomasmoors,
Does this also occur in a private/incognito window on desktop?
I have a feeling this may occur if the iframe attempts to go through the authentication process, and hence go across a different domain or go to the google accounts domain which may not allow embedding.
You could update your
ALLOWED_IFRAME_SOURCESto instead containhttps://*.google.comto allow all google subdomains but it may not help if it's the subdomain site itself which is preventing use within an iframe.@thomasmoors commented on GitHub (Jun 15, 2022):
Adding the wildcard fixed it. Good thinking, for me it's weird the iframe behaves differently.