mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 09:09:38 +03:00
[Feature Request]: Video scrubbing #2661
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexphillips-dev on GitHub (Feb 21, 2022).
Describe the feature you'd like
Scrubbing in the video player to allow moving the slider along the timeline back and forth in order to get the needed point right away, without waiting when the track reaches this moment “in a natural way”.
Describe the benefits this feature would bring to BookStack users
Our use case is uploading videos recorded from Teams to a Bookstack page with multiple video files for our training chapter. Would be nice if when users return to the page they don't have to wait for the video to slowly play again back to where they were, they could just move the slider forward and pick up where they left off.
Additional context
No response
@s00500 commented on GitHub (Mar 23, 2022):
There also seems a bug involved here: in Firefox one can at least jump to places in a video, but in chrome based browsers the bar just jumps back and the video continues where it was... seems to be a chrome thing with the video tag... have not found a nice way around it yet
@ssddanbrown commented on GitHub (Mar 23, 2022):
Related to #882, May close/merge this into that in the future.
If you host the video somewhere that can properly support range requests (Most webservers can do this) then scrubbing should work fine. BookStack's attachment serving does not currently support range requests hence the lack of scrubbing.
@jennso commented on GitHub (Jul 15, 2022):
Has anyone found a workaround for this or has it been implemented, my goal is to have embedded mp4 videos that can be scrubbed and skip while playing.
Thank You!
@LHBL2003 commented on GitHub (Apr 15, 2023):
I would also be happy if it works in Chrome. in Firefox, fast forwarding it still works.
@ssddanbrown commented on GitHub (Jan 17, 2024):
Range request support has been added in PR #4758, to be part of the next feature release.
This allows video scrubbing. There are some limitations for this, if using cloud (s3) storage but those concerns could be raised separately if an issue, otherwise should work for most cases.
That PR also eases adding videos from attachments by adding them as a video embed automatically when dragged in from the attachments bar (or when the link button is used).
Note though, browsers can treat videos in different ways, likely depending on a number of factors. Worked fine in my testing although Safari could act strange and often still want to download the whole video in a single big chunk, although this may change depending on network conditions and other factors.