mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-05-04 18:08:46 +03:00
[Feature Request]: Theme Select #2631
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reddexx on GitHub (Feb 3, 2022).
Describe the feature you'd like
Hi there,
Since the darkmode is not going so well, I have another idea of choosing a topic
So you could adjust the complete CSS without the dark mode variable
I have an example as CSS code
The excerpt comes from the Darkreader (tool)
Describe the benefits this feature would bring to BookStack users
Not only the simplification of the styles but also the provision of a number of topics would be guaranteed
Additional context
Dark.zip
@ssddanbrown commented on GitHub (Feb 3, 2022):
Hi @reddexx,
To be honest, I don't understand the majority of this request. I'm not sure what feature you're asking for or what problem you're attempting to solve. I don't understand what you're referring to as "topics".
Is there another way to describe what you want here, or what you'd expect us to action based upon this request?
@reddexx commented on GitHub (Feb 3, 2022):
Visual-Style from Bookstack over CSS
this ist not the Dark-Mode. This is my Edit over CSS Declaration
@ssddanbrown commented on GitHub (Feb 3, 2022):
Okay, Are you expecting us to action anything based upon this request or are you just sharing your CSS edits for the community?
@reddexx commented on GitHub (Feb 3, 2022):
My idea would be that you can choose a css-style like you can see on the picture (on the right). BookStack checks if there are CSS files in the directory and takes the filename as the style name, which can be selected in the menu. The selected CSS should then be used
@reddexx commented on GitHub (Feb 3, 2022):
A style selection menu is better than the current darkmode
@ssddanbrown commented on GitHub (Feb 3, 2022):
Ah, I see now. I'm not looking to change direction in how dark mode has been approached. We build it in to make usage easier while having the dark mode theme supported and aligned to the default light mode. This follows the "batteries included" approach I try to keep to but that does mean we have to keep our scope focused to keep things maintainable. A lot of the reasoning above is quite opinionated and does not justify the benefits for the wider bookstack audience.
While I could maybe see a desire in some use cases for per-user selection of custom styles, that would be an edge case scenario and a more complex parallel to the light/dark system we already support.
@ssddanbrown commented on GitHub (Feb 4, 2022):
Will therefore close this off.