mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-02-06 09:09:38 +03:00
[Bug Report]: Animated webp images partially supported - behave strangely #2555
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @paviro on GitHub (Jan 4, 2022).
Describe the Bug
When I noticed #3136 I tried a couple of other animated image formats one of them webp.
When uploading a normal webp image everything is fine. When containing animations however the image uploads just fine but doesn't show a preview.
When adding the image to the document it is displayed like you can see in the background. Clicking on it show the source to be null.
Removing the image and adding it again has the same result. Clicking on the folder on the existing image with the null resource and adding it from here results in this:
The question mark image can be removed and the animated webp stays in tackt now but only if you add it this way.
Steps to Reproduce
See above.
Expected Behaviour
Animated webp images should behave as normal webp images do.
Screenshots or Additional Context
No response
Exact BookStack Version
BookStack v21.12
PHP Version
8.0
Hosting Environment
Debian with Nginx as webserver
@ssddanbrown commented on GitHub (Jan 7, 2022):
Just checked this out, Appears to be more complicated than GIF or APNG.
Animated webp is not supported by libgd, so we cannot currently create thumbnails for these where required. They are uploaded but their gallery thumbnail will be missing as shown and since their display size is not generated they are added to a page with issue. imagemagick may support these images but don't want to swap out the image driver just because of this case.
Maybe we change the page implementation to use the original file link if no thumbnails exist, Not sure about the gallery though, I don't want to be loading in full image versions. Might just need to have a better placeholder.
@paviro commented on GitHub (Jan 7, 2022):
Maybe a note when you upload one saying that it isn’t supported at the moment (until libgd supports it) is the best solution?
@ssddanbrown commented on GitHub (Jan 7, 2022):
Maybe, but to do that we'd need to sniff out if it's an animated webp image before storing, which produces another single-purpose edge-case in the logic. The above could apply for any scenarios where we can't produce thumbnails.
@ssddanbrown commented on GitHub (Jan 10, 2022):
I've now applied
941217d9fbwhich will do as per my comment above (Improved gallery backup placeholder in addition to using original image url in editors if display thumbnail does not exist). Have tested with animated webp and it seems to do the job, allows usage where desired without harsh breaking although no thumbnail shown in gallery. Think this is a suitable middle ground.This will be part of the next patch release. Will therefore close this off. Thanks again @paviro for reporting.
@paviro commented on GitHub (Jan 10, 2022):
Sounds good, thank you!