mirror of
https://github.com/BookStackApp/BookStack.git
synced 2026-07-16 05:33:49 +03:00
[Bug Report]: Create-Permission in Shelves #2502
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SammyTV9825 on GitHub (Nov 23, 2021).
Describe the Bug
Create-Permission in Shelves does not show up when permission is granted
Steps to Reproduce
Expected Behaviour
A Create-Button should appear on the right side (actions menu)
Screenshots or Additional Context
Create-Button appears with other buttons (edit, delete) if their permission is granted (sometimes)
Exact BookStack Version
21.11
PHP Version
No response
Hosting Environment
Docker container
@ssddanbrown commented on GitHub (Nov 23, 2021):
Hi @Sammysamsi,
Could you confirm exactly where you're attempting to set permissions (Step 3) and exactly where you're looking in regards to Step 4?
Both of these steps are somewhat ambiguous and could mean multiple things so just want to nail down the exact flow to re-produce this.
@SammyTV9825 commented on GitHub (Nov 23, 2021):
The role itself has no permissions.
The shelve permissions allows the user to view the shelve, create books, edit the shelve and delete the shelve
Now I am navigating into the shelve and the actions menu only displays the edit- and delete-button. The add/create-button is missing (Should be the first item)
When I am granting these permissions to the role itself...
...its showing all buttons as they should be displayed
If thats not clear enough let me know. I also might have found another problem. I'll check that first before i open another report.
Edit: I am viewing Bookstack with an user that has only this role (its the default one) and there are no other perms set for the shelve.
Edit2: Just want to say that i cant reproduce the situation of the create-button showing up when the edit- and delete-perms are granted (As mentioned in "Screenshots or Additional Context").
@ssddanbrown commented on GitHub (Nov 23, 2021):
Thanks @Sammysamsi for the detail.
Is this only apparent for shelves? If so I think this may have already been raised under #2690. The shelf create permission is currently redundant.
@SammyTV9825 commented on GitHub (Nov 23, 2021):
Thats probably the same issue. I am sorry for that. I did not found any more issues with permissions right now.
@ssddanbrown commented on GitHub (Nov 23, 2021):
@Sammysamsi No worries, that other issue was pretty hard to track down to be fair, but had it in the back of my mind. Thanks for making the effort to report!